Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ante): allow rejection based on depth #1443

Merged

Conversation

danwt
Copy link
Contributor

@danwt danwt commented Nov 8, 2024

Description


Closes #XXX

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow-up issues.

PR review checkboxes:

I have...

  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Targeted PR against the correct branch
  • included the correct type prefix in the PR title
  • Linked to the GitHub issue with discussion and accepted design
  • Targets only one GitHub issue
  • Wrote unit and integration tests
  • Wrote relevant migration scripts if necessary
  • All CI checks have passed
  • Added relevant godoc comments
  • Updated the scripts for local run, e.g genesis_config_commands.sh if the PR changes parameters
  • Add an issue in the e2e-tests repo if necessary

SDK Checklist

  • Import/Export Genesis
  • Registered Invariants
  • Registered Events
  • Updated openapi.yaml
  • No usage of go map
  • No usage of time.Now()
  • Used fixed point arithmetic and not float arithmetic
  • Avoid panicking in Begin/End block as much as possible
  • No unexpected math Overflow
  • Used sendCoin and not SendCoins
  • Out-of-block compute is bounded
  • No serialized ID at the end of store keys
  • UInt to byte conversion should use BigEndian

Full security checklist here


For Reviewer:

  • Confirmed the correct type prefix in the PR title
  • Reviewers assigned
  • Confirmed all author checklist items have been addressed

After reviewer approval:

  • In case the PR targets the main branch, PR should not be squash merge in order to keep meaningful git history.
  • In case the PR targets a release branch, PR must be rebased.

@danwt danwt requested a review from a team as a code owner November 8, 2024 13:31
omritoptix
omritoptix previously approved these changes Nov 8, 2024
app/ante/reject_msgs.go Outdated Show resolved Hide resolved
app/ante/reject_msgs.go Show resolved Hide resolved
app/ante/reject_msgs.go Show resolved Hide resolved
app/ante/reject_msgs.go Show resolved Hide resolved
app/ante/reject_msgs.go Show resolved Hide resolved
x/lightclient/ante/ibc_msg_update_client.go Outdated Show resolved Hide resolved
app/ante/reject_msgs.go Show resolved Hide resolved
for _, pred := range rmd.predicates {
if pred(typeURL, depth) {
return gerrc.ErrInvalidArgument.Wrapf("disabled grant: %s", typeURL)
}
}
default:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure why no return nil here
why u need to go through return rmd.checkMsgs(ctx, inner, depth+1) with empty inner to stop the recursion

@omritoptix omritoptix merged commit 17b5be7 into main Nov 11, 2024
5 checks passed
@omritoptix omritoptix deleted the danwt/1367-allow-custom-conditional-in-reject-message-handler branch November 11, 2024 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants