Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(delayedack): added efficient query for pending packets by addr #1385

Merged
merged 7 commits into from
Nov 4, 2024

Conversation

keruch
Copy link
Contributor

@keruch keruch commented Nov 3, 2024

Description


Closes #1382

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow-up issues.

PR review checkboxes:

I have...

  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Targeted PR against the correct branch
  • included the correct type prefix in the PR title
  • Linked to the GitHub issue with discussion and accepted design
  • Targets only one GitHub issue
  • Wrote unit and integration tests
  • Wrote relevant migration scripts if necessary
  • All CI checks have passed
  • Added relevant godoc comments
  • Updated the scripts for local run, e.g genesis_config_commands.sh if the PR changes parameters
  • Add an issue in the e2e-tests repo if necessary

SDK Checklist

  • Import/Export Genesis
  • Registered Invariants
  • Registered Events
  • Updated openapi.yaml
  • No usage of go map
  • No usage of time.Now()
  • Used fixed point arithmetic and not float arithmetic
  • Avoid panicking in Begin/End block as much as possible
  • No unexpected math Overflow
  • Used sendCoin and not SendCoins
  • Out-of-block compute is bounded
  • No serialized ID at the end of store keys
  • UInt to byte conversion should use BigEndian

Full security checklist here


For Reviewer:

  • Confirmed the correct type prefix in the PR title
  • Reviewers assigned
  • Confirmed all author checklist items have been addressed

After reviewer approval:

  • In case the PR targets the main branch, PR should not be squash merge in order to keep meaningful git history.
  • In case the PR targets a release branch, PR must be rebased.

@keruch keruch requested a review from omritoptix November 3, 2024 17:11
@keruch keruch self-assigned this Nov 3, 2024
@keruch keruch requested a review from a team as a code owner November 3, 2024 17:11
@keruch keruch changed the title feat(delayedack): added effective query to get all pending packets by… feat(delayedack): added efficient query for pending packets by addr Nov 3, 2024
Copy link

codecov bot commented Nov 3, 2024

Codecov Report

Attention: Patch coverage is 53.68421% with 44 lines in your changes missing coverage. Please review.

Project coverage is 23.04%. Comparing base (0a553f9) to head (f646b28).
Report is 20 commits behind head on main.

Files with missing lines Patch % Lines
x/delayedack/keeper/rollapp_packet.go 59.61% 14 Missing and 7 partials ⚠️
x/delayedack/ibc_middleware.go 33.33% 8 Missing and 4 partials ⚠️
x/delayedack/genesis.go 16.66% 4 Missing and 1 partial ⚠️
x/delayedack/client/cli/query.go 0.00% 3 Missing ⚠️
x/delayedack/types/query.pb.go 0.00% 2 Missing ⚠️
x/delayedack/keeper/grpc_query.go 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1385      +/-   ##
==========================================
- Coverage   23.71%   23.04%   -0.68%     
==========================================
  Files         553      562       +9     
  Lines      117635   122365    +4730     
==========================================
+ Hits        27903    28195     +292     
- Misses      85941    90378    +4437     
- Partials     3791     3792       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

x/delayedack/keeper/rollapp_packet.go Outdated Show resolved Hide resolved
x/delayedack/ibc_middleware.go Outdated Show resolved Hide resolved
x/delayedack/keeper/rollapp_packet.go Outdated Show resolved Hide resolved
@omritoptix omritoptix marked this pull request as draft November 4, 2024 09:55
@keruch keruch marked this pull request as ready for review November 4, 2024 13:27
@keruch keruch requested a review from mtsitrin November 4, 2024 13:27
omritoptix
omritoptix previously approved these changes Nov 4, 2024
@keruch keruch requested a review from omritoptix November 4, 2024 15:44
@mtsitrin mtsitrin merged commit d577982 into main Nov 4, 2024
5 checks passed
@mtsitrin mtsitrin deleted the kirill/1382-get-all-finalizable-packets branch November 4, 2024 17:15
omritoptix pushed a commit that referenced this pull request Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Efficeient query to get all finalizable packets per address
3 participants