feat(eibc): filtering per rollapp level when granting authorization #1375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
omritoptix
approved these changes
Nov 1, 2024
| @@ -50,7 +50,7 @@ Examples: | |||
| return fmt.Errorf("failed to parse grantee address: %w", err) | |||
| } | |||
|
|
|||
| rollapps, err := cmd.Flags().GetStringSlice(FlagRollapps) | |||
| rollappID, err := cmd.Flags().GetString(FlagRollapp) | |||
There was a problem hiding this comment.
not critical but for the CLI it's better to probably have a way to pass a file with the definition otherwise we're limited for 1 rollapp per operator vs multiple (cause it will override).
the portal can do it though so should be fine.
| @@ -50,7 +50,7 @@ Examples: | |||
| return fmt.Errorf("failed to parse grantee address: %w", err) | |||
| } | |||
|
|
|||
| rollapps, err := cmd.Flags().GetStringSlice(FlagRollapps) | |||
| rollappID, err := cmd.Flags().GetString(FlagRollapp) | |||
| if err != nil { | |||
| return fmt.Errorf("failed to get rollapps: %w", err) | |||
There was a problem hiding this comment.
Suggested change
| return fmt.Errorf("failed to get rollapps: %w", err) | |
| return fmt.Errorf("failed to get rollapp: %w", err) |
| @@ -142,7 +146,7 @@ Examples: | |||
| } | |||
|
|
|||
| flags.AddTxFlagsToCmd(cmd) | |||
| cmd.Flags().StringSlice(FlagRollapps, []string{}, "An array of Rollapp IDs allowed") | |||
| cmd.Flags().StringSlice(FlagRollapp, []string{}, "An array of Rollapp IDs allowed") | |||
There was a problem hiding this comment.
is it an array? seems like we're handling just one rollapp
|
I'll merge. create a technical debt issue for it as they arent blocking. |
omritoptix
changed the title
omritoptix
deleted the
zale144/restructure-fulfill-order-authorization
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #XXX
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow-up issues.
PR review checkboxes:
I have...
Unreleasedsection inCHANGELOG.mdgodoccommentsSDK Checklist
maptime.Now()sendCoinand notSendCoinsFull security checklist here
For Reviewer:
After reviewer approval: