fix(genesis bridge): get rollapp by light client ID rather than chain ID in transfer enabled check #1339
Conversation
| // 2. It is for rollapp but the light client of this transfer is not yet canonical or will never | ||
| // be marked canonical: for a correct rollapp the transfer channel is only created after it's | ||
| // marked canonical, so this transfer corresponds to a not-relevant channel. | ||
| // Note: IBC prevents sending to a channel which is not OPEN, which prevents making the transfer |
There was a problem hiding this comment.
IFAIU, channel can be established and OPEN even before we have canonical channel set, which set on the first state update.
which means the channel will be enabled until the canonical channel will be set?
There was a problem hiding this comment.
such channel will never be canonical so not important, such a rollapp is improperly created
btw I acknowledge it's awkward, it's due to a bad decision to make canonical client lazy instead of making it on the hub with the rollapp, but we are not going to change it for 3d release
There was a problem hiding this comment.
such channel will never be canonical so not important,
oh I see it now.
channel can be canonical only if established over already canonical client.
channel established before the client became canonical (even if it's going to be soon), will not be canonical.
thx
There was a problem hiding this comment.
yeah! sorry I know it's confusing
|
@danwt UT fails |
Description
Closes #1324
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow-up issues.
PR review checkboxes:
I have...
Unreleasedsection inCHANGELOG.mdgodoccommentsSDK Checklist
maptime.Now()sendCoinand notSendCoinsFull security checklist here
For Reviewer:
After reviewer approval: