Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(light client): adds query for canonical client for rollapp #1158

Merged
merged 31 commits into from
Sep 4, 2024
Merged

feat(light client): adds query for canonical client for rollapp #1158

merged 31 commits into from
Sep 4, 2024

Conversation

danwt
Copy link
Contributor

@danwt danwt commented Aug 30, 2024

Description

Closes #XXX

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow-up issues.

PR review checkboxes:

I have...

  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Targeted PR against the correct branch
  • included the correct type prefix in the PR title
  • Linked to the GitHub issue with discussion and accepted design
  • Targets only one GitHub issue
  • Wrote unit and integration tests
  • Wrote relevant migration scripts if necessary
  • All CI checks have passed
  • Added relevant godoc comments
  • Updated the scripts for local run, e.g genesis_config_commands.sh if the PR changes parameters
  • Add an issue in the e2e-tests repo if necessary

SDK Checklist

  • Import/Export Genesis
  • Registered Invariants
  • Registered Events
  • Updated openapi.yaml
  • No usage of go map
  • No usage of time.Now()
  • Used fixed point arithmetic and not float arithmetic
  • Avoid panicking in Begin/End block as much as possible
  • No unexpected math Overflow
  • Used sendCoin and not SendCoins
  • Out-of-block compute is bounded
  • No serialized ID at the end of store keys
  • UInt to byte conversion should use BigEndian

Full security checklist here

For Reviewer:

  • Confirmed the correct type prefix in the PR title
  • Reviewers assigned
  • Confirmed all author checklist items have been addressed

After reviewer approval:

  • In case the PR targets the main branch, PR should not be squash merge in order to keep meaningful git history.
  • In case the PR targets a release branch, PR must be rebased.

@danwt danwt marked this pull request as ready for review September 2, 2024 11:18
@danwt danwt requested a review from a team as a code owner September 2, 2024 11:18
@danwt danwt changed the title test light client feat(light client): adds query for canonical client for rollapp Sep 2, 2024
omritoptix
omritoptix reviewed Sep 3, 2024
View reviewed changes
Copy link
Contributor

@omritoptix omritoptix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good. 2 questions though.

x/lightclient/types/params.go Outdated
TrustLevel: ibctm.NewFractionFromTm(math.Fraction{Numerator: 1, Denominator: 3}),
// TrustingPeriod is the duration of the period since the
// LatestTimestamp during which the submitted headers are valid for update.
TrustingPeriod: time.Hour * 24 * 10,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldnt it be a percentage of the unbonding period? what if we change the unbonding period?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, right, I meant to put a TODO here
I will add todo and issue

x/lightclient/types/params.go
// that must sign over a new untrusted header before it is accepted.
// At LEAST this much must sign over the untrusted header. Voting sets all have power
// 1, so at least 1/3 of power 1 is 1.
TrustLevel: ibctm.NewFractionFromTm(math.Fraction{Numerator: 1, Denominator: 3}),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know 1/3 is still valid, but don't you think 1/1 is cleaner? what's the reason to change it back to 1/3?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tendermint bug
Doesn't support 1/1, because they do a > operation (not >=)
I'm submitting to hackerone

@omritoptix omritoptix merged commit 031ecad into main Sep 4, 2024
16 of 129 checks passed
@omritoptix omritoptix deleted the danwt/test-light-client branch September 4, 2024 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@omritoptix omritoptix omritoptix approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@danwt @omritoptix