fix(rollapp): logo size now 40kib #1092
Conversation
WalkthroughThe recent changes enhance flexibility in handling data URIs within the Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (2)
- proto/dymensionxyz/dymension/rollapp/metadata.proto (1 hunks)
- x/rollapp/types/rollapp.go (1 hunks)
Additional comments not posted (1)
x/rollapp/types/rollapp.go (1)
45-45: LGTM! Ensure documentation reflects the updated size limit.The increase of
maxDataURILengthfrom 25KB to 40KB is consistent with the PR objectives. Ensure that any related documentation or comments are updated to reflect this new limit.
| // logo_data_uri is a base64 rep with a URI prefix to the rollapp logo. Size limited | ||
| string logo_data_uri = 3; | ||
| // token_logo_data_uri is a URI to the native token logo. Should be limited to 25kb. | ||
| // token_logo_data_uri is a URI to the native token logo. Size limited |
There was a problem hiding this comment.
Clarify the size limitations in comments.
The comments for logo_data_uri and token_logo_data_uri have been simplified to "Size limited," which might lead to ambiguity. Consider specifying the size limit to avoid confusion among developers.
- // logo_data_uri is a base64 rep with a URI prefix to the rollapp logo. Size limited
+ // logo_data_uri is a base64 rep with a URI prefix to the rollapp logo. Max size: 40KB
- // token_logo_data_uri is a URI to the native token logo. Size limited
+ // token_logo_data_uri is a URI to the native token logo. Max size: 40KBCommittable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| // logo_data_uri is a base64 rep with a URI prefix to the rollapp logo. Size limited | |
| string logo_data_uri = 3; | |
| // token_logo_data_uri is a URI to the native token logo. Should be limited to 25kb. | |
| // token_logo_data_uri is a URI to the native token logo. Size limited | |
| // logo_data_uri is a base64 rep with a URI prefix to the rollapp logo. Max size: 40KB | |
| string logo_data_uri = 3; | |
| // token_logo_data_uri is a URI to the native token logo. Max size: 40KB |
Description
Closes #1091
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow-up issues.
PR review checkboxes:
I have...
Unreleasedsection inCHANGELOG.mdgodoccommentsSDK Checklist
maptime.Now()sendCoinand notSendCoinsFull security checklist here
----;
For Reviewer:
---;
After reviewer approval:
Summary by CodeRabbit
New Features
Documentation