Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Istanbul is deprecated, migrate to NYC #286

Closed
oleg-koval opened this issue Mar 6, 2019 · 2 comments
Closed

Istanbul is deprecated, migrate to NYC #286

oleg-koval opened this issue Mar 6, 2019 · 2 comments

Comments

@oleg-koval
Copy link
Member

During npm install i receive this:

This module is no longer maintained, try this instead: npm i nyc Visit https://istanbul.js.org/integrations for other alternatives.

Also package-lock.json is missing.

I already have a branch with following migration, if its needed I can open a PR

@oleg-koval oleg-koval changed the title Istambul is deprecated, missing package-lock.json Istanbul is deprecated, missing package-lock.json Mar 6, 2019
@nelsonic
Copy link
Member

nelsonic commented Mar 6, 2019

Hi @oleg-koval thank you for opening this issue!
If you have already done the work, please PR the change from istanbul to nyc 👍
(we are aware of it and it's on our list of things to update: dwyl/learn-istanbul#20 ...)
Our reasoning for leaving the package-lock.json file out of version control is that it creates a lot of noise whenever something is updated (without much benefit to the users) ...

@oleg-koval
Copy link
Member Author

@nelsonic I understand your concern about package-lock

@oleg-koval oleg-koval changed the title Istanbul is deprecated, missing package-lock.json Istanbul is deprecated, migrate to NYC Mar 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants