[fix] Correctly handle dual SPDX/legacy license identifiers

The license inspection was incorrectly handling license identifiers
that appear as both legacy identifiers in the license database as well
as SPDX expressions.  The core problem is that under the legacy
system, there was a lot of identifier reuse.  This patch refactors how
the license inspection notes the dual licenses so that the inspection
passes on packages that have migrated to SPDX.

Fixes: rpminspect#1387

Signed-off-by: David Cantrell <[email protected]>

Author: dcantrell

lib/init.c

@@ -599,28 +599,17 @@ static inline void _remedy_walker(struct toml_node *node, void *data)
         r = toml_value_as_string(node);
 
         if (r) {
-            entry = calloc(1, sizeof(*entry));
-            assert(entry != NULL);
-            entry->data = r;
-
-            if (ri->remedy_overrides == NULL) {
-                ri->remedy_overrides = calloc(1, sizeof(*(ri->remedy_overrides)));
-                assert(ri->remedy_overrides != NULL);
-                TAILQ_INIT(ri->remedy_overrides);
-            }
+            ri->remedy_overrides = list_add(ri->remedy_overrides, r);
 
-            TAILQ_INSERT_TAIL(ri->remedy_overrides, entry, items);
-        }
-
-        if (!set_remedy(n, r)) {
-            warnx("*** '%s' is not a valid remedy identifier", n);
-
-            if (r) {
+            if (!set_remedy(n, r)) {
+                warnx("*** '%s' is not a valid remedy identifier", n);
                 TAILQ_REMOVE(ri->remedy_overrides, entry, items);
                 free(entry->data);
                 free(entry);
             }
         }
+
+        free(r);
     }
 
     free(n);