Skip to content
This repository has been archived by the owner on Nov 7, 2023. It is now read-only.

Shortened skill orders don't have full accuracy for first 3-4 skills #32

Closed
mpcomplete opened this issue May 16, 2015 · 2 comments
Closed

Comments

@mpcomplete
Copy link

A skill order like http://champion.gg/champion/Quinn is shortened to "Q>E>W" in both the Most Frequent and Highest Win Rate builds. But one starts with "QEWQ" and the other starts with "QEQW". I recommend you separate the first 3-4 skills and list them in addition to the shortened order.

I mentioned this in the reddit thread but I'm not sure if I was clear about what I meant. See https://github.com/mpcomplete/lisa/blob/master/lib/js/outputFormat.js#L84 for the way I handle this (there's no need to sort the skills - you know if a skill is finished by level 9 that it is maxed, and by level 13 that it is second-to-max.)

@dustinblackman
Copy link
Owner

Something like this then?
Trinkets | Q.E.W.Q - Q>E>W

@mpcomplete
Copy link
Author

Perfect!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants