Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compressed source seems to break CI workflows that install duckdb #612

Closed
andrewGhazi opened this issue Nov 26, 2024 · 2 comments · Fixed by #634
Closed

Compressed source seems to break CI workflows that install duckdb #612

andrewGhazi opened this issue Nov 26, 2024 · 2 comments · Fixed by #634
Milestone

Comments

@andrewGhazi
Copy link

andrewGhazi commented Nov 26, 2024

Hi there -- I have a Carpentries training module that depends on duckdb and installs the package on a Github runner image to generate the online version. However the relatively recent addition of the xz compressed source directory seems to be breaking the Github actions that orchestrate this process. See the log here:

https://github.com/carpentries-incubator/bioc-scrnaseq/actions/runs/12036979601/job/33559404345#step:6:2590

By the time it gets to tar cvJf duckdb.tar.xz duckdb that directory seems to be gone. I guess it's deleted early somehow, maybe it's the cleanup script somehow running before configure or something? It's hard to tell exactly what's going on, but it does seem to be a relatively recent bug as another workflow from a few weeks ago that used duckdb_1.1.2 from CRAN succeeded.

Maybe this is my workflow's problem, but I thought I would flag the issue here since it was pretty tricky to track down. It would be nice not to have to pin the module to an old duckdb version.

@krlmlr krlmlr added this to the 1.1.3-1 milestone Dec 4, 2024
@krlmlr
Copy link
Collaborator

krlmlr commented Dec 4, 2024

Thanks. It looks like we need to make ./cleanup reentrant: check if .tar.xz exists, if yes, do nothing.

@andrewGhazi
Copy link
Author

Hi there, unfortunately the update in 1.1.13-1 doesn't seem to have fixed the issue for me. I wish I could be of more help but I can't tell why the compression command is getting run given the update in #634 ... The error log is pretty much the same as last time:

  
  * installing *source* package ‘duckdb’ ...
  ** package ‘duckdb’ successfully unpacked and MD5 sums checked
  ** using staged installation
  + [ -f duckdb.tar.xz ]
  + which xz
  + [ -d .git ]
  + cd src
  + tar cvJf duckdb.tar.xz duckdb
  tar: duckdb: Cannot stat: No such file or directory
  tar: Exiting with failure status due to previous errors
  + dirname ./configure
  + cd ./src
  + [ -f  ]
  + cp include/to-tar.mk Makevars.duckdb
  + [ -f duckdb.tar.xz ]
  + tar xJf duckdb.tar.xz
  ** libs
  using C++ compiler: ‘g++ (Ubuntu 11.4.0-1ubuntu1~22.04) 11.4.0’
  using C++17
  make: *** No rule to make target 'duckdb/ub_src_catalog.o', needed by 'duckdb.tar'.  Stop.
  ERROR: compilation failed for package ‘duckdb’
  * removing ‘/home/runner/work/bioc-scrnaseq/bioc-scrnaseq/renv/profiles/lesson-requirements/renv/library/linux-ubuntu-jammy/R-4.4/x86_64-pc-linux-gnu/.renv/1/duckdb’
  install of package 'duckdb' failed [error code 1]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants