Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rustflag unification seems to be broken in certain situations #290

Closed
weiznich opened this issue Oct 18, 2024 · 2 comments · Fixed by #293
Closed

Rustflag unification seems to be broken in certain situations #290

weiznich opened this issue Oct 18, 2024 · 2 comments · Fixed by #293

Comments

@weiznich
Copy link
Contributor

I observe different outputs for diesels compile tests depending on whether I have the following ~/.cargo/config.toml file:

[target.]
linker = "clang"
rustflags = ["-C", "link-arg=-fuse-ld=/usr/bin/mold"]

If the file exists it seems like trybuild does not pass the --verbose flag to the compiler, if it doesn't exist it will pass that flag, which results in widely different output.

That's with trybuild 1.0.100 and rust 1.82.0 using the x86_64-unknown-linux-gnu target

@dtolnay
Copy link
Owner

dtolnay commented Oct 18, 2024

I was able to reproduce this and observed that it's fixed by #293. Please let me know if those tests still fail on your end.

@weiznich
Copy link
Contributor Author

Thanks for the fast fix ❤️

I can confirm that this now works for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants