Add Lifetime span getter and setter #971
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This matches the
span
andset_span
accessors we provide on all the variousLit
variant types.Lifetimes are ordinarily treated as a single token. Only the proc macro API splits them into
'
punctuation and ident. Consequently the span of those two things is normally identical, except in pathological case when manually constructed from within a proc macro with differing spans. Thus, requiring macros to decide whether to writelifetime.apostrophe.span
orlifetime.ident.span()
for that span makes the code misleading. The new accessors reflect the fact that really there is only one span involved.For example rustc parsers
'a
as the following TokenStream, in which byte range95..97
covers both characters of the entire'a
token.