Fix parsing of path type wrapped in a None-delimited group
#944
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, `peek2` was used to check for `::` or `<` following a
`None`-delimited group. However, `peek2` will look *inside*` a
`None`-delimited group, so this code would treat input like
`{{ Vec<u8> }}` as having an angle bracket *after* the `None`-delimited
group.
We now consume the `None`-delimited group by parsing it, and then use
`peek` to check for tokens that occur *after* the `None`-delimited
group.
|
@dtolnay Are there any changes that you'd like me to make? |
dtolnay
approved these changes
Dec 20, 2020
This was referenced Mar 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously,
peek2was used to check for::or<following aNone-delimited group. However,peek2will look inside aNone-delimited group, so this code would treat input like{{ Vec<u8> }}as having an angle bracket after theNone-delimitedgroup.
We now consume the
None-delimited group by parsing it, and then usepeekto check for tokens that occur after theNone-delimitedgroup.