Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

less and grep can't use the preparser #96

Open
nfischer opened this issue Aug 26, 2016 · 2 comments
Open

less and grep can't use the preparser #96

nfischer opened this issue Aug 26, 2016 · 2 comments
Labels

Comments

@nfischer
Copy link
Collaborator

Currently, less and grep can't take advantage of the preparser (since they're in separate modules). Here's some possible solutions:

  1. move vorpal-less and vorpal-grep into cash
  2. move the preparser to a separate module, and allow vorpal-less and vorpal-grep to require it
  3. since glob expansion works for these commands, we could consider moving the preparser code to be right before or right after that.

This should be resolved if cash switches over to vorpaljs/bash-parser (since I believe that will handle all the expansion).

@parro-it
Copy link

This should be resolved if cash switches over to vorpaljs/bash-parser (since I believe that will handle all the expansion).

@nfisher, I could help with the transition, let me know how I can help you...

@nfischer
Copy link
Collaborator Author

@parro-it I think the most important thing right now is to just get vorpal/bash-parser solid. The next step would probably be to switch vorpal itself to rely on that parser. After that, we may want to make an extra module just for bash-like expansion (glob expansion, variable expansion, tilde expansion, etc.).

After that, we can basically say that vorpal = bash-parser + executing registered commands, while cash = vorpal + implementation of unix commands + performing shell expansion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants