Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple chapters from the TOC on this source can't be grabbed anymore if TOC has sub-headings #1195

Closed
bonnetchuu opened this issue Feb 9, 2024 · 3 comments

Comments

@bonnetchuu
Copy link

Hello! Hoping this is not a bother to you, but I recently started using WebToEpub again and found that there's an error with an old source that has a pre-existing parser which wasn't present previously in an older version of the extension --> https://exiledrebelsscanlations.com/

There are some novels on this source, wherein the Table of Contents page includes textual sub-headings that are not hyperlinks coming between a portion of the chapters. So, when WebToEpub tries to generate the TOC of chapter links, when it reaches a sub-heading, the extension seems to hit a bump and does not generate any chapter links further than the occurrence of the first sub-heading, thereby only grabbing a portion of the chapters out of the majority of links.

A couple novels which has this error (due to the emplacement of sub-headings) are:

https://exiledrebelsscanlations.com/novels/mecha-slave-contract/

https://exiledrebelsscanlations.com/novels/the-governors-illness/

Please refer to the below image for reference, wherein the double underline in red (+ the cross) indicates when WebToEpub stops and fails to proceed in grabbing the remainder of chapters due to the impediment of the first occurring sub-heading [that's encircled in blue].

image

Just for a note, all other novels which do not include sub-headings as part of the TOC do not pertain to this issue. But, for the novels which do have sub-headings, it would be greatly appreciated if this error could somehow be rectified. Thank you!!! :)

@bonnetchuu bonnetchuu changed the title Multiple chapters from the TOC on this source can't be grabbed anymore Multiple chapters from the TOC on this source can't be grabbed anymore if TOC has sub-headings Feb 9, 2024
@dteviot
Copy link
Owner

dteviot commented Feb 12, 2024

@bonnetchuu

Fix supplied by ImLJS

Test versions for Firefox and Chrome have been uploaded to https://drive.google.com/drive/folders/1B_X2WcsaI_eg9yA-5bHJb8VeTZGKExl8?usp=sharing. Pick the one suitable for you, follow the "How to install from Source (for people who are not developers)" instructions at https://github.com/dteviot/WebToEpub/tree/ExperimentalTabMode#user-content-how-to-install-from-source-for-people-who-are-not-developers and let me know how it goes.
Tested with:

For my notes: 15 minutes work

@bonnetchuu
Copy link
Author

Thank you, it fixed the issue!

@dteviot
Copy link
Owner

dteviot commented Mar 22, 2024

@bonnetchuu

Updated version (0.0.0.158) has been submitted to Firefox store and is available now
Due to technical issues (i.e. I pressed the wrong button) updated version can't be submitted to Chrome store for an indefinite period.
Chrome might be available in 6 to 42 days.

@dteviot dteviot closed this as completed Mar 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants