Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add highlight for keywords #4

Open
gjvnq opened this issue Jan 22, 2020 · 2 comments
Open

Add highlight for keywords #4

gjvnq opened this issue Jan 22, 2020 · 2 comments

Comments

@gjvnq
Copy link

gjvnq commented Jan 22, 2020

Hi, I think that the special rules should have their own highlight.

I think adding this bit of code would suffice:

- match: '\b(ANY|SOI|EOI|WHITESPACE|COMMENT|PUSH|POP)\b'
      scope: keyword

What do you think?

@dten
Copy link
Owner

dten commented Jan 22, 2020

I don't think keyword is quite right. And this would make navigation to their definition (in the case of whitespace and comment) not work.
I'll have a think. Probably one of the support types is better

@giraffekey
Copy link

I get highlights for ASCII_ALPHANUMERIC, ANY, NEWLINE, etc, but not for ASCII_ALPHA, ASCII_DIGIT, or various others.

To stay consistent I think everything mentioned on this page should be highlighted: https://pest.rs/book/grammars/built-ins.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants