Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is deserialize_symbols still a valid safety concern? #97

Open
jules2689 opened this issue Aug 19, 2020 · 0 comments
Open

Is deserialize_symbols still a valid safety concern? #97

jules2689 opened this issue Aug 19, 2020 · 0 comments

Comments

@jules2689
Copy link

Hey all,

I have a question about the deserialize_symbols safety concern.

since symbols are not garbage collected in Ruby and so deserializing them from YAML may render your application vulnerable to a DOS (denial of service) attack. To allow symbol deserialization by default:

It seems that Ruby 2.2+ is able to GC symbols, so is SafeYAML::OPTIONS[:deserialize_symbols] to false valid anymore?

Rails is starting to use the symbolize_names feature, which is not supported on SafeYAML, and things are silently breaking.

If we no longer need this safety mechanism, should it be removed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant