Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revisiting #35: Discarding timezone data #85

Open
t-brink opened this issue Apr 18, 2017 · 2 comments
Open

Revisiting #35: Discarding timezone data #85

t-brink opened this issue Apr 18, 2017 · 2 comments

Comments

@t-brink
Copy link

t-brink commented Apr 18, 2017

I would like to quickly discuss #35 again. I'm planning to prepare a patch for jekyll to keep the timezone data (read with SafeYAML) intact, see jekyll/jekyll#6033. This is impossible without monkey patching SafeYAML, as already indicated in #35. The patch itself is trivial.

Is the decision on closing #35 final? Would it be possible to somehow get an option for this behavior? The current implementation discards useful data and I would hate monkey patching this if I can avoid it.

@pathawks
Copy link

Jekyll would really like to at least have the option of preserving the timezone. There have been some strange issues where the post timezone and site timezone differ in such a way that a posts date seems to be different from what the user specified. If the date is used in the URL, this can be very confusing.

@t-brink
Copy link
Author

t-brink commented May 20, 2017

I opened a pull request to fix this issue: #87

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants