Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fxLayoutWrap no longer exists #204

Open
jihuiwang opened this issue Feb 23, 2018 · 13 comments · May be fixed by #230
Open

fxLayoutWrap no longer exists #204

jihuiwang opened this issue Feb 23, 2018 · 13 comments · May be fixed by #230

Comments

@jihuiwang
Copy link

I was using material design framework but received an error
Can't bind to 'fxLayoutWrap' since it isn't a known property of 'flex-layout-root-widget'.

I checked angular/flex-layout on github and found that fxLayoutWrap was removed since Nov 30, 2017.

@jihuiwang
Copy link
Author

it is used in 'src/lib/src/framework-library/material-design-framework/flex-layout-section.component.ts'

@oliverrenner
Copy link

same issue here!!

@jihuiwang
Copy link
Author

@oliverrenner
remove the [fxLayoutWrap] Directive from the template in 'src/lib/src/framework-library/material-design-framework/flex-layout-section.component.ts'
make it work

@Koslun
Copy link

Koslun commented Mar 3, 2018

@jihuiwang
To be precise, it was removed in 5.0.0-beta.13 on 22nd February in 2018 but was deprecated earlier, maybe the date you mentioned. See https://github.com/angular/flex-layout/blob/master/CHANGELOG.md#breaking-changes

If the fxLayoutWrap directive is there a corresponding wrap should likely be added to the fxLayout property to keep the same functionality. I.e. from fxLayout="row" to fxLayout="row wrap"

@beeing
Copy link

beeing commented Mar 3, 2018

use fxLayout="row wrap"

@jihuiwang
Copy link
Author

@Koslun
yes, the error appears with the latest version of angular/flex-layout, which is 5.0.0-beta.13
now i roll back to the previous one (2.0.0-beta.12).
and it works again.

@Koslun
Copy link

Koslun commented Mar 6, 2018

@jihuiwang yes, I've done the same for now.

@rroeneman
Copy link

Work around, removing the (part of) line
[fxLayoutWrap]="options?.fxLayoutWrap"\n
from angular2-json-schema-form.es5 file, worked for me to upgrade to flex-layout 5.0.0-beta.13.
Not fully tested yet, but could help...

@j2L4e j2L4e linked a pull request Mar 13, 2018 that will close this issue
@vatsalpande
Copy link

Any update on this issue? Facing the same

@Koslun
Copy link

Koslun commented Mar 26, 2018

@vatsalpande fixed in PR #230

@catchshyam
Copy link

Any ETA on the release that includes PR #230 ?

@Theyssen
Copy link

Does anyone have a solution in anticipation of the pull request?

@Koslun
Copy link

Koslun commented Apr 23, 2018

@Theyssen Using a forked version of this repo containing the above PR. Steps to do so are described in above PR: #230 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants