Preserve legacy manage_script actions, handle validation levels, and add framing safety check

[dsarno]

Summary

• keep deprecated manage_script read/update/edit actions as compatibility aliases with warnings
• handle CRLF newlines correctly when mapping line/column to index
• flag IDE config mismatches when auto-manage is disabled
• support explicit 'basic', 'standard', 'strict', and 'comprehensive' validation levels
• cap framed response length in socket test
• pin Python 3.11 version for pyright

Testing

• pytest -q

---

https://chatgpt.com/codex/tasks/task_e_68a083d83a108327a0cb602fdeb3b1a7

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing Touches

🧪 Generate unit tests

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch codex/update-managescript-for-backward-compatibility-g252rq

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

• Visit our Status Page to check the current availability of CodeRabbit.
• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[greptile-apps]

Greptile Summary

This PR introduces several backward compatibility improvements and safety enhancements to the Unity MCP project. The primary focus is on restoring deprecated manage_script actions (read, update, edit) as compatibility aliases while maintaining deprecation warnings to guide users toward newer alternatives. The changes also expand validation level support to include 'standard' and 'comprehensive' options alongside existing 'basic' and 'strict' levels.

Key technical improvements include better CRLF newline handling when mapping line/column positions to string indices - a critical fix for Windows environments where text editors use different line ending conventions. The PR also enhances IDE configuration mismatch detection by ensuring these issues are surfaced even when auto-manage is disabled, improving troubleshooting visibility.

For testing infrastructure, the PR adds a 128MB safety cap for framed response lengths in socket tests to prevent memory exhaustion from corrupted protocol frames. Additionally, Python 3.11 is now explicitly pinned in the Pyright configuration to ensure consistent type checking across different development environments.

These changes integrate well with the existing codebase by preserving API compatibility while gradually encouraging migration to preferred methods. The validation level expansion fits naturally into the existing switch-based validation system in ManageScript.cs.

Important Files Changed

Files Modified (4 files)

Filename	Score	Overview
UnityMcpBridge/Editor/Tools/ManageScript.cs	4/5	Restores deprecated actions as compatibility aliases with warnings and improves CRLF newline handling
UnityMcpBridge/Editor/Windows/UnityMcpEditorWindow.cs	5/5	Adds IDE configuration mismatch detection when auto-manage is disabled
UnityMcpBridge/UnityMcpServer~/src/pyrightconfig.json	5/5	Pins Python 3.11 version for consistent type checking across environments
test_unity_socket_framing.py	4/5	Adds 128MB safety cap for framed response lengths to prevent memory issues

Confidence score: 4/5

• This PR is relatively safe to merge with some areas requiring attention due to backward compatibility changes
• Score reflects solid safety improvements and defensive programming, but complexity in ManageScript.cs changes requires careful review
• Pay close attention to ManageScript.cs for potential edge cases in CRLF handling and deprecated action routing

Sequence Diagram

sequenceDiagram
    participant User
    participant MCP_Client as MCP Client
    participant Unity_Bridge as Unity Bridge
    participant ManageScript as ManageScript Handler
    participant ValidationEngine as Validation Engine
    participant FileSystem as File System
    participant EditorWindow as Editor Window

    User->>MCP_Client: "Request script operation"
    MCP_Client->>Unity_Bridge: "Send manage_script command"
    
    alt Framing Protocol Check
        Unity_Bridge->>Unity_Bridge: "Check response length limits"
        Note over Unity_Bridge: Cap framed response to prevent overflow
    end
    
    Unity_Bridge->>ManageScript: "HandleCommand(params)"
    ManageScript->>ManageScript: "Extract action, name, path, contents"
    ManageScript->>ManageScript: "Validate parameters"
    ManageScript->>ManageScript: "TryResolveUnderAssets(path)"
    
    alt Legacy Action Warning
        Note over ManageScript: If action is 'read', 'update', or 'edit'
        ManageScript->>ManageScript: "Log deprecation warning"
        ManageScript->>ManageScript: "Continue with backward compatibility"
    end
    
    alt Action: validate
        ManageScript->>ManageScript: "Parse validation level (basic/standard/strict/comprehensive)"
        ManageScript->>FileSystem: "Read script file"
        FileSystem-->>ManageScript: "File contents"
        ManageScript->>ValidationEngine: "ValidateScriptSyntax(contents, level)"
        
        alt Roslyn Available
            ValidationEngine->>ValidationEngine: "Use Roslyn compiler services"
        else Fallback
            ValidationEngine->>ValidationEngine: "Use basic structure validation"
        end
        
        ValidationEngine-->>ManageScript: "Validation results with diagnostics"
        ManageScript-->>Unity_Bridge: "Formatted diagnostics response"
    end
    
    alt Action: apply_text_edits
        ManageScript->>FileSystem: "Read current file"
        FileSystem-->>ManageScript: "Current contents"
        ManageScript->>ManageScript: "Check precondition SHA256"
        ManageScript->>ManageScript: "Convert line/col to indices (handle CRLF)"
        ManageScript->>ManageScript: "Validate edit ranges don't overlap"
        ManageScript->>ManageScript: "Apply edits from back to front"
        ManageScript->>ManageScript: "Check balanced delimiters"
        
        opt Roslyn Validation
            ManageScript->>ValidationEngine: "Parse and validate syntax"
            ValidationEngine-->>ManageScript: "Syntax check results"
        end
        
        ManageScript->>FileSystem: "Atomic write with temp file"
        ManageScript->>ManageScript: "Schedule asset refresh"
    end
    
    alt Action: create/update (legacy)
        ManageScript->>EditorWindow: "Get validation level from GUI settings"
        EditorWindow-->>ManageScript: "Current validation level"
        ManageScript->>ValidationEngine: "ValidateScriptSyntax(contents, level)"
        ValidationEngine-->>ManageScript: "Validation results"
        
        alt Validation Failed
            ManageScript-->>Unity_Bridge: "Error response with details"
        else Validation Passed
            ManageScript->>FileSystem: "Write script file atomically"
            ManageScript->>ManageScript: "Schedule debounced refresh"
            ManageScript-->>Unity_Bridge: "Success response"
        end
    end
    
    Unity_Bridge->>Unity_Bridge: "Apply framing safety check"
    Unity_Bridge-->>MCP_Client: "Return response (framed if protocol supports)"
    MCP_Client-->>User: "Operation result"

Loading

_{4 files reviewed, no comments}

_{Edit Code Review Bot Settings | Greptile}