Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gitignore is not considered when making patches. #254

Open
gomain opened this issue Sep 6, 2020 · 0 comments · May be fixed by #262
Open

gitignore is not considered when making patches. #254

gomain opened this issue Sep 6, 2020 · 0 comments · May be fixed by #262

Comments

@gomain
Copy link
Contributor

gomain commented Sep 6, 2020

Unintended files, e.g. editor temp files, leak into created patches. These are usually set to be ignored by git one way or another.

patch-package should respect the repo's gitignore settings when creating patches.
gomain added a commit to gomain/patch-package that referenced this issue Sep 7, 2020
@gomain
exclude git-ignored files from patch creation
075c5a1 
fixes ds300#254
gomain added a commit to gomain/patch-package that referenced this issue Sep 7, 2020
@gomain
exclude git-ignored files from patch creation
5f78e24 
fixes ds300#254
gomain added a commit to gomain/patch-package that referenced this issue Sep 8, 2020
@gomain
exclude git-ignored files from patch creation
ce78034 
fixes ds300#254
gomain added a commit to gomain/patch-package that referenced this issue Sep 8, 2020
@gomain
exclude git-ignored files from patch creation
754d5d6 
fixes ds300#254
@gomain gomain linked a pull request Sep 10, 2020 that will close this issue
Open
@RA80533 RA80533 mentioned this issue Apr 24, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add --git-ignore option gomain/patch-package
1 participant
@gomain