Fix argument remapping. Limit remapping to first argument. #3326
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sutharsan
changed the title
Member
|
Thanks ... The old code had consistently wrong spelling or no? if yes, then I dont see how a spelling fix can eliminate the bug. I cant find the actual spelling inconsistency except for in Doxygen |
Member
|
If we're going to call this fixed, it would be helpful to have a failing test that passes when the fix is applied. |
Contributor
Author
|
@weitzman not consistenly wrong, no. See line 50 (old code) that uses correct spelling |
Contributor
Author
|
Minimal unittest added. |
weitzman
reviewed
Jan 28, 2018
tests/ArgsRemapperTest.php
Outdated
|
|
||
| namespace Unish; | ||
|
|
||
| use \Drush\Preflight\argsRemapper; |
Member
There was a problem hiding this comment.
Capital A in class name, not 'a'.
Contributor
Author
|
Done |
Contributor
Author
|
:) Thanks
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3295 by limiting the remapping to the first argument (properly).