Fixes #4004: Do not set tty mode if stdout is redirected. (#4028)

Author: greg-1-anderson

.scenarios.lock/php5/composer.json

@@ -64,7 +64,7 @@
         "consolidation/output-formatters": "^3.3.1",
         "consolidation/robo": "^1.4.6",
         "consolidation/site-alias": "^3.0.0@stable",
-        "consolidation/site-process": "^2.0.0@stable",
+        "consolidation/site-process": "^2.0.1",
         "grasmash/yaml-expander": "^1.1.1",
         "league/container": "~2",
         "psr/log": "~1.0",

.scenarios.lock/php5/composer.lock

@@ -40,7 +40,7 @@
     "consolidation/output-formatters": "^3.3.1",
     "consolidation/robo": "^1.4.6",
     "consolidation/site-alias": "^3.0.0@stable",
-    "consolidation/site-process": "^2.0.0@stable",
+    "consolidation/site-process": "^2.0.1",
     "grasmash/yaml-expander": "^1.1.1",
     "league/container": "~2",
     "psr/log": "~1.0",

composer.json

@@ -100,7 +100,7 @@ public function redispatch(InputInterface $input)
         if (!TerminalUtils::isTty()) {
             $process->setInput(STDIN);
         } else {
-            $process->setTty($this->getConfig()->get('ssh.tty', $input->isInteractive()));
+            $process->setTty($this->getConfig()->get('ssh.tty', TerminalUtils::useTty() && $input->isInteractive()));
         }
         $process->mustRun($process->showRealtime());
 

composer.lock

@@ -5,8 +5,9 @@
 class TerminalUtils
 {
     /**
-     * isTty determines if the STDIN stream is a TTY. If we cannot tell,
-     * then we return a default value.
+     * isTty determines if the STDIN stream is a TTY. We use this function
+     * to determine whether or not we should redirect input of a process
+     * using our STDIN stream. If we cannot tell, then we return a default value.
      *
      * @param bool $default Result to assume when the posix functions
      *   are not available.
@@ -20,4 +21,22 @@ public static function isTty($default = true)
 
         return posix_isatty(STDIN);
     }
+
+    /**
+     * useTty determines if both the STDIN and STDOUT streams connect to a TTY.
+     * We use this to determine whether we should use tty mode with our process
+     * component. If we cannot tell, then we return a default value.
+     *
+     * @param bool $default Result to assume when the posix functions
+     *   are not available.
+     * @return bool
+     */
+    public static function useTty($default = true)
+    {
+        if (!function_exists('posix_isatty')) {
+            return $default;
+        }
+
+        return posix_isatty(STDOUT) && posix_isatty(STDIN);
+    }
 }