Issue #3023729 by tim.plunkett, bkosborne, xjm: LayoutBuilderController should iterate over components in a region using Element::children()

Author: xjm

modules/layout_builder/src/Controller/LayoutBuilderController.php

@@ -6,6 +6,7 @@
 use Drupal\Core\DependencyInjection\ContainerInjectionInterface;
 use Drupal\Core\Messenger\MessengerInterface;
 use Drupal\Core\Plugin\PluginFormInterface;
+use Drupal\Core\Render\Element;
 use Drupal\Core\StringTranslation\StringTranslationTrait;
 use Drupal\Core\Url;
 use Drupal\layout_builder\Context\LayoutBuilderContextTrait;
@@ -209,7 +210,7 @@ protected function buildAdministrativeSection(SectionStorageInterface $section_s
 
     foreach ($layout_definition->getRegions() as $region => $info) {
       if (!empty($build[$region])) {
-        foreach ($build[$region] as $uuid => $block) {
+        foreach (Element::children($build[$region]) as $uuid) {
           $build[$region][$uuid]['#attributes']['class'][] = 'draggable';
           $build[$region][$uuid]['#attributes']['data-layout-block-uuid'] = $uuid;
           $build[$region][$uuid]['#contextual_links'] = [

modules/layout_builder/tests/modules/layout_builder_test/src/Plugin/Layout/LayoutBuilderTestPlugin.php

@@ -0,0 +1,29 @@
+<?php
+
+namespace Drupal\layout_builder_test\Plugin\Layout;
+
+use Drupal\Core\Layout\LayoutDefault;
+
+/**
+ * @Layout(
+ *   id = "layout_builder_test_plugin",
+ *   label = @Translation("Layout Builder Test Plugin"),
+ *   regions = {
+ *     "main" = {
+ *       "label" = @Translation("Main Region")
+ *     }
+ *   },
+ * )
+ */
+class LayoutBuilderTestPlugin extends LayoutDefault {
+
+  /**
+   * {@inheritdoc}
+   */
+  public function build(array $regions) {
+    $build = parent::build($regions);
+    $build['main']['#attributes']['class'][] = 'go-birds';
+    return $build;
+  }
+
+}

modules/layout_builder/tests/src/Functional/LayoutBuilderTest.php

@@ -536,6 +536,26 @@ public function testDeletedView() {
     $assert_session->pageTextNotContains('Test Block View');
   }
 
+  /**
+   * Tests that sections can provide custom attributes.
+   */
+  public function testCustomSectionAttributes() {
+    $assert_session = $this->assertSession();
+    $page = $this->getSession()->getPage();
+
+    $this->drupalLogin($this->drupalCreateUser([
+      'configure any layout',
+      'administer node display',
+    ]));
+
+    $this->drupalPostForm('admin/structure/types/manage/bundle_with_section_field/display/default', ['layout[enabled]' => TRUE], 'Save');
+    $page->clickLink('Manage layout');
+    $page->clickLink('Add Section');
+    $page->clickLink('Layout Builder Test Plugin');
+    // See \Drupal\layout_builder_test\Plugin\Layout\LayoutBuilderTestPlugin::build().
+    $assert_session->elementExists('css', '.go-birds');
+  }
+
   /**
    * Tests the usage of placeholders for empty blocks.
    *