Skip to content

Commit 138c7d3

Browse files
committed
Issue #2995150 by msankhala, tim.plunkett: Command examples in core/tests/README.md are confusing and not executable
(cherry picked from commit 93e12b0)
1 parent 9a3dac1 commit 138c7d3

File tree

1 file changed

+16
-16
lines changed

1 file changed

+16
-16
lines changed

tests/README.md

Lines changed: 16 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -4,9 +4,9 @@
44

55
* Run the functional tests:
66
```
7-
export SIMPLETEST_DB='mysql://root@localhost/dev_d8'
8-
export SIMPLETEST_BASE_URL='http://d8.dev'
9-
./vendor/bin/phpunit -c core --testsuite functional
7+
export SIMPLETEST_DB='mysql://root@localhost/dev_d8';
8+
export SIMPLETEST_BASE_URL='http://d8.dev';
9+
./vendor/bin/phpunit -c core --testsuite functional;
1010
```
1111

1212
Note: functional tests have to be invoked with a user in the same group as the
@@ -50,8 +50,8 @@ For help installing and starting selenium, see http://mink.behat.org/en/latest/d
5050
Example for Mac:
5151

5252
```
53-
brew install selenium-server-standalone
54-
brew install chromedriver
53+
brew install selenium-server-standalone;
54+
brew install chromedriver;
5555
```
5656

5757
* Before running tests make sure that selenium-server is running
@@ -61,24 +61,24 @@ selenium-server -port 4444
6161

6262
* Set the correct driver args and run the tests:
6363
```
64-
export MINK_DRIVER_ARGS_WEBDRIVER='["chrome", null, "http://localhost:4444/wd/hub"]'
65-
./vendor/bin/phpunit -c core --testsuite functional-javascript
64+
export MINK_DRIVER_ARGS_WEBDRIVER='["chrome", null, "http://localhost:4444/wd/hub"]';
65+
./vendor/bin/phpunit -c core --testsuite functional-javascript;
6666
```
6767

6868
* It is possible to use alternate browsers if the required dependencies are
6969
installed. For example to use Firefox:
7070

7171
```
72-
export MINK_DRIVER_ARGS_WEBDRIVER='["firefox", null, "http://localhost:4444/wd/hub"]'
73-
./vendor/bin/phpunit -c core --testsuite functional-javascript
72+
export MINK_DRIVER_ARGS_WEBDRIVER='["firefox", null, "http://localhost:4444/wd/hub"]';
73+
./vendor/bin/phpunit -c core --testsuite functional-javascript;
7474
```
7575

7676
* To force all BrowserTestBase (including legacy JavascriptTestBase) tests to use
7777
webdriver:
7878

7979
```
80-
export MINK_DRIVER_CLASS='Drupal\FunctionalJavascriptTests\DrupalSelenium2Driver'
81-
./vendor/bin/phpunit -c core --testsuite functional-javascript
80+
export MINK_DRIVER_CLASS='Drupal\FunctionalJavascriptTests\DrupalSelenium2Driver';
81+
./vendor/bin/phpunit -c core --testsuite functional-javascript;
8282
```
8383

8484
## Running legacy javascript tests
@@ -93,7 +93,7 @@ have to install and start PhantomJS.
9393

9494
* Then you can run the test:
9595
```
96-
./vendor/bin/phpunit -c core --testsuite functional-javascript
96+
./vendor/bin/phpunit -c core --testsuite functional-javascript;
9797
```
9898

9999
## Running tests with a different user
@@ -102,10 +102,10 @@ If the default user is e.g. `www-data`, the above functional tests will have to
102102
be invoked with sudo instead:
103103

104104
```
105-
export SIMPLETEST_DB='mysql://root@localhost/dev_d8'
106-
export SIMPLETEST_BASE_URL='http://d8.dev'
107-
sudo -u www-data -E ./vendor/bin/phpunit -c core --testsuite functional
108-
sudo -u www-data -E ./vendor/bin/phpunit -c core --testsuite functional-javascript
105+
export SIMPLETEST_DB='mysql://root@localhost/dev_d8';
106+
export SIMPLETEST_BASE_URL='http://d8.dev';
107+
sudo -u www-data -E ./vendor/bin/phpunit -c core --testsuite functional;
108+
sudo -u www-data -E ./vendor/bin/phpunit -c core --testsuite functional-javascript;
109109
```
110110

111111
## Nightwatch tests

0 commit comments

Comments
 (0)