Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decimal point/comma problem with predefined frequencies #570

Closed
JohBod opened this issue Oct 13, 2023 · 7 comments
Closed

Decimal point/comma problem with predefined frequencies #570

JohBod opened this issue Oct 13, 2023 · 7 comments

Comments

@JohBod
Copy link

JohBod commented Oct 13, 2023

FreeDV version: 1.9.2
OS: Win10, Swedish (which uses comma as decimal separator)

The predefined frequencies in the "Report Frequency" drop-down list are all red. This happens because they have decimal points instead of decimal commas. Selecting a red frequency from the list results in reporting the MHz digits correctly but all the decimals become zero e.g. 14.2360 becomes 14,0000 in the FreeDV reporter window and 14.0000 on https://qso.freedv.org/.

I was able to temporarily fix the problem by replacing '.' with ',' in all the entries in Tools/Options.../Rig Control/Predefined Frequencies. However, after stopping and restarting FreeDV, the list becomes totally messed up. It looks like all the commas have been replaced by newlines :) See attached screeshot.

73 Johan SM6LKM

bild

@Tyrbiter
Copy link

PR #561 resolves this, it will be included in the next release when that is ready.

@JohBod
Copy link
Author

JohBod commented Oct 13, 2023

Where is the frequency list stored? I couldn't find it neither in C:\Users\jbodi\AppData\Roaming nor in the Windows registry.

By the way, the "FreeDV User Manual Oct 13 2023 3a5154d" points to HKEY_CURRENT_USER\SOFTWARE\CODEC2-Project\FreeDV\ which doesn't exist in my PC. Instead I found some FreeDV configuration here HKEY_CURRENT_USER\SOFTWARE\FreeDV.

73

@Tyrbiter
Copy link

On my Linux system it's in the .freedv file in my home directory under the:

[Reporting]
...
FrequencyList=
...

key, I'm unfamiliar with the Windows arrangement.

@tmiw will be able to tell you, but the PR I referred to is intended to deal with locale issues where decimal separators and number delimiters are now recognised correctly.

@tmiw
Copy link
Collaborator

tmiw commented Oct 13, 2023

Where is the frequency list stored? I couldn't find it neither in C:\Users\jbodi\AppData\Roaming nor in the Windows registry.

Yeah, HKEY_CURRENT_USER\SOFTWARE\freedv\Reporting\FrequencyList on Windows. The default for that is "3.6250,3.6430,3.6930,3.6970,5.4035,5.3665,7.1770,14.2360,14.2400,18.1180,21.3130,24.9330,28.3300,28.7200,10489.6400".

I'll update the documentation to reflect the actual Registry location.

EDIT: #571

@Tyrbiter
Copy link

The location for Linux is ~/.freedv, the manual says ~/.FreeDV so I suppose that should be edited too :-p

@tmiw
Copy link
Collaborator

tmiw commented Oct 14, 2023

The location for Linux is ~/.freedv, the manual says ~/.FreeDV so I suppose that should be edited too :-p

Yep. #572

@tmiw
Copy link
Collaborator

tmiw commented Oct 24, 2023

I think this is resolved, so closing for now.

@tmiw tmiw closed this as completed Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants