Merge pull request #705 from drowe67/ms-leak-cleanup

Resolve memory leak in FreeDV Reporter window.

Author: tmiw

USER_MANUAL.md

@@ -895,6 +895,7 @@ LDPC | Low Density Parity Check Codes - a family of powerful FEC codes
     * Cache PortAudio sound info to improve startup performance. (PR #689)
     * Fix typo in cardinal directions list. (PR #688)
     * Shrink size of callsign list to prevent it from disappearing off the screen. (PR #692)
+    * Clean up memory leak in FreeDV Reporter window. (PR #705)
     * Fix issue causing delayed filter updates when going from tracking band to frequency. (PR #704)
 2. Enhancements:
     * Add additional error reporting in case of PortAudio failures. (PR #695)

src/gui/dialogs/freedv_reporter.cpp

@@ -395,7 +395,8 @@ FreeDVReporterDialog::FreeDVReporterDialog(wxWindow* parent, wxWindowID id, cons
 FreeDVReporterDialog::~FreeDVReporterDialog()
 {
     m_highlightClearTimer->Stop();
-    
+    delete m_highlightClearTimer;
+
     m_trackFrequency->Disconnect(wxEVT_COMMAND_CHECKBOX_CLICKED, wxCommandEventHandler(FreeDVReporterDialog::OnFilterTrackingEnable), NULL, this);
     m_trackFreqBand->Disconnect(wxEVT_RADIOBUTTON, wxCommandEventHandler(FreeDVReporterDialog::OnFilterTrackingEnable), NULL, this);
     m_trackExactFreq->Disconnect(wxEVT_RADIOBUTTON, wxCommandEventHandler(FreeDVReporterDialog::OnFilterTrackingEnable), NULL, this);

src/pipeline/test/ExclusiveAccessTest.cpp

@@ -26,7 +26,7 @@ bool exclusiveAccessMethodsCalled()
     pVal[0] = 10000;
 
     int outputSamples = 0;
-    std::shared_ptr<short> input(pVal);
+    std::shared_ptr<short> input(pVal, std::default_delete<short[]>());
     auto result = exclusiveAccessStep.execute(input, 1, &outputSamples);
 
     if (outputSamples != 1)
@@ -66,4 +66,4 @@ int main()
 {
     TEST_CASE(exclusiveAccessMethodsCalled);
     return 0;
-}
+}

src/pipeline/test/LevelAdjustTest.cpp

@@ -9,7 +9,7 @@ bool levelAdjustCommon(float val)
     short* pData = new short[1];
     pData[0] = 10000;
 
-    auto result = levelAdjustStep.execute(std::shared_ptr<short>(pData), 1, &outputSamples);
+    auto result = levelAdjustStep.execute(std::shared_ptr<short>(pData, std::default_delete<short[]>()), 1, &outputSamples);
     if (outputSamples != 1)
     {
         std::cerr << "[outputSamples[" << outputSamples << "] != 1]...";
@@ -41,4 +41,4 @@ int main()
     TEST_CASE(levelAdjustUp);
     TEST_CASE(levelAdjustDown);
     return 0;
-}
+}

src/pipeline/test/TapTest.cpp

@@ -25,7 +25,7 @@ bool tapDataEqual()
     short* pData = new short[1];
     pData[0] = 10000;
 
-    std::shared_ptr<short> input(pData);
+    std::shared_ptr<short> input(pData, std::default_delete<short[]>());
     auto result = tapStep.execute(input, 1, &outputSamples);
     if (outputSamples != 1)
     {
@@ -51,4 +51,4 @@ int main()
 {
     TEST_CASE(tapDataEqual);
     return 0;
-}
+}