Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add wechat alarm notify, refactor code #1516

Merged
merged 6 commits into from
Jan 26, 2024
Merged

add wechat alarm notify, refactor code #1516

merged 6 commits into from
Jan 26, 2024

Conversation

Carpe-Wang
Copy link
Contributor

@Carpe-Wang Carpe-Wang commented Jan 25, 2024

What's changed?

  • 做了一个idea建议的改动
  • 做了一些todo,但是逻辑不完善

Checklist

  • I hereby agree to the terms of the HertzBeat CLA
  • I have read the Contributing Guide
  • I have written the necessary doc or comment.
  • I have added the necessary unit tests and all cases have passed.

Add or update API

  • I have added the necessary e2e tests and all cases have passed.

@tomsun28 tomsun28 changed the title solve Todo support wechat alarm notify Jan 25, 2024
@tomsun28 tomsun28 changed the title support wechat alarm notify add wechat alarm notify, refactor code Jan 26, 2024
@tomsun28 tomsun28 added the enhancement New feature or request label Jan 26, 2024
Copy link
Contributor

@tomsun28 tomsun28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍👍

@tomsun28 tomsun28 merged commit 7fb4ec0 into master Jan 26, 2024
2 checks passed
@Carpe-Wang Carpe-Wang deleted the todosolve branch January 26, 2024 09:12
tomsun28 pushed a commit that referenced this pull request Mar 9, 2024
tomsun28 pushed a commit that referenced this pull request Mar 9, 2024
tomsun28 pushed a commit that referenced this pull request Mar 9, 2024
tomsun28 pushed a commit that referenced this pull request Mar 10, 2024
tomsun28 pushed a commit that referenced this pull request Mar 10, 2024
tomsun28 pushed a commit that referenced this pull request Mar 11, 2024
tomsun28 pushed a commit that referenced this pull request Mar 11, 2024
tomsun28 pushed a commit that referenced this pull request Mar 11, 2024
tomsun28 pushed a commit that referenced this pull request Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants