refactor tdengine store code, auto close resource #1513
Merged
+14
−24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomsun28
added
enhancement
tomsun28
changed the title
tomsun28
reviewed
Jan 24, 2024
Comment on lines
245
to
250
| if (!serverAvailable) { | ||
| log.error("\n\t---------------TdEngine Init Failed---------------\n" + | ||
| "\t--------------Please Config Tdengine--------------\n" + | ||
| "\t----------Can Not Use Metric History Now----------\n"); | ||
| return instanceValuesMap; | ||
| } |
There was a problem hiding this comment.
👍👍 LGTM! hi，suggest put this before the connection.
There was a problem hiding this comment.
okay, I done the suggestion.
tomsun28
pushed a commit
that referenced
this pull request
Mar 9, 2024
Co-authored-by: Carpe-Wang <[email protected]>
tomsun28
pushed a commit
that referenced
this pull request
Mar 9, 2024
Co-authored-by: Carpe-Wang <[email protected]>
tomsun28
pushed a commit
that referenced
this pull request
Mar 9, 2024
Co-authored-by: Carpe-Wang <[email protected]>
tomsun28
pushed a commit
that referenced
this pull request
Mar 10, 2024
Co-authored-by: Carpe-Wang <[email protected]>
tomsun28
pushed a commit
that referenced
this pull request
Mar 10, 2024
Co-authored-by: Carpe-Wang <[email protected]>
tomsun28
pushed a commit
that referenced
this pull request
Mar 11, 2024
Co-authored-by: Carpe-Wang <[email protected]>
tomsun28
pushed a commit
that referenced
this pull request
Mar 11, 2024
Co-authored-by: Carpe-Wang <[email protected]>
tomsun28
pushed a commit
that referenced
this pull request
Mar 11, 2024
Co-authored-by: Carpe-Wang <[email protected]>
tomsun28
pushed a commit
that referenced
this pull request
Mar 11, 2024
Co-authored-by: Carpe-Wang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changed?
在解决fix #1419，发现和代码问题关系不大，就简单优化了下代码
记录所有的SQLException分别catch，然后就是把finally代码块用try-with-resources语句自动管理资源替代，目的是在出现异常时，可以更简洁地确保资源被正确关闭。
Checklist
Add or update API