Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dal#T issues #79

Open
stewSquared opened this issue Oct 25, 2017 · 1 comment
Open

Dal#T issues #79

stewSquared opened this issue Oct 25, 2017 · 1 comment

Comments

@stewSquared
Copy link
Contributor

stewSquared commented Oct 25, 2017

There are a few problems.

  1. monadT should be in the implicit scope. We shouldn't be importing slickDal.monadT everywhere
  2. T : Monad is too strong of a constraint. Applicative suffices.
  3. The name T is often clashes and is not descriptive enough. Even if we're to keep a single letter name, F (for Functor) is more standard and semantic.

Feel free to add more to this thread. It should all be updated at once.

@jodersky
Copy link
Member

jodersky commented Oct 25, 2017

  1. monadT should be in the implicit scope. We shouldn't be importing slickDal.monadT everywhere

+1000 to this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants