Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Confirm that all backends properly iterate over directories #15

Closed
pjbull opened this issue Aug 17, 2020 · 2 comments · Fixed by #202
Closed

Confirm that all backends properly iterate over directories #15

pjbull opened this issue Aug 17, 2020 · 2 comments · Fixed by #202
Labels
bug Something isn't working

Comments

@pjbull
Copy link
Member

pjbull commented Aug 17, 2020

Most cloud services don't have a notion of a "directory." We try to add this back in within our logic by doing our own path splitting.

We should make sure that the pathlib methods (glob and iterdir) and our methods do the same thing of:

  • Returning directories and/or files when iterating
  • Returning the root or current directory when being asked to iter or not
  • Sort order of the returned results (may not be possible/worth it since we use a generator)
@pjbull
Copy link
Member Author

pjbull commented Aug 27, 2020

@pjbull pjbull added the bug Something isn't working label Oct 2, 2020
@karolzlot
Copy link
Contributor

For at least S3 it works differently than in-built Path: it includes also current folder.

It should be fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants