-
Notifications
You must be signed in to change notification settings - Fork 13.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(chore): Add packaging for Meteor.js #3133
Conversation
30114ec
to
7daad0b
Compare
This is out of the scope for v1 of Ionic, but support is coming in v2. |
👍
Could you provide examples of code or tutos of a such architecture ? @perrygovier So, meteor will be "built-in" supported by ionic2/angular2 ? |
👍 |
Thank @Urigo and @perrygovier! @perrygovier With the buss for Ionic 2.0 do you have an Alpha or Beta tester ETA |
👍 @skolade ! |
@rbecheras, the way Angular 2 and es6 itself is architected means angular and ionic wont conflict the same way it currently does, requiring a special project to smooth over the differences. We've already started development on Ionic 2 and are in regular communication with the Angular team, building Ionic 2 as new features and functionality of Angular 2 are built out. Ionic 2 and Angular 2 are still very volatile still though. We will open source it when the dust settles a bit more. |
+1 for official integration of meteor and ionic! |
Thanks @perrygovier, I'm pretty impatient to read the ionic announce ;-) |
Thanks @Urigo, angular-meteor library is amazing, when i start working with it one of my major problem was where is Ionic..? Meteor-Ionic solved it & it feel more comfortable. i wish these all libraries will work on ionic2 & angular2 also. |
+1 for official integration Thank you @Urigo ! |
+1 for official integration! |
👍 |
+1 for official integration Thank you @Urigo ! |
+1 for official integration |
+1 for official integration! |
+1 ! |
+1 |
9 similar comments
+1 |
+1 |
+1 |
+1 |
+1 |
👍 |
+1 |
+1 |
+1 |
Is there a thread talking about making it easier / possible to use the ionic CLI inside Meteor? |
Also how would I implement this? Would I need to use Angular? I'm currently On Sat, Aug 22, 2015, 7:04 AM chrisbarry [email protected] wrote:
|
@chrisbarry @nicholasalanbrown I'm working on a blog post the will be out soon that will demonstrate both ways of doing that (Using Meteor CLI and using the Ionic CLI) |
@Urigo — great news. |
+1 |
@@ -0,0 +1,6 @@ | |||
// disable fastclick package in Meteor if included |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Urigo is there any way we can avoid this? The PR looks good, just we're not too keen on this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mhartington Why? this code cancels Meteor's FastClick so we will your yours like any other Ionic app
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We'd like to avoid having a meteor
directory in the root of Ionic. We're not opposed to what it's doing, but is there another way to do it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ohh I see, then I can place it inside the package.js I think.
Or in any other place you want me to
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No actually not in the package.js, but any other place you want..
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Playing devil's advocate, is it possible for metor to check for ionic.tap
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you mean inside the fastclick package?
My guess is that probably not and if so, it might take a while (like next version or something)
The good thing about that is here it's out of both of the platforms specific code and only in the integrating package
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can also rename to folder to something more general like packaging
or place it inside scripts
or config
which has build specific things
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If there's a file that accommodates a package manager, cool. So package.js is ok. I'd like to avoid functional code that gets added to the ionic.bundle.min.js whose only purpose is to accommodate other libraries. Is it possible to add that bit of code to another repo and include it via package.js? I know it seems silly, but it's a precedent that could bite us later if we don't do things right.
+1 |
+1! |
+1 |
@mhartington @perrygovier I've moved the |
+1 |
+1! |
+1 |
2 similar comments
+1 |
+1 |
It is there now: https://atmospherejs.com/driftyco/ionic |
ha, missed a char in my commit message. This has been added! Thanks for your patience and efforts. |
Great, Wonderful work your contributions towards Meteor is really mind-blowing keep up the good work. |
Will we be able to use this package in the future without any angular dependency? Now that iconic doesn't require angular anymore, it would be great to use this official package instead of meteoric. |
I concur. Integration with alternatives like React would be awesome. On Sat, Oct 3, 2015 at 5:03 AM Luis Herranz [email protected]
|
Yep, being able to use Ionic with Meteor+Blaze or Meteor+React would be incredible. |
Ionic is still using Angular, and we're pretty happy with it.
|
For those interested, here is a link to the @Urigo's tutorial about building an ionic app with meteor. |
Hi @adamdbradley @mlynch
I'm a package maintainer for Meteor.js, a popular full-stack JavaScript framework.
I'm also the creator of angular-meteor, a library that let's you work with AngularJS on top of Meteor.
A lot of our users use Ionic and it right now there is a separate package and Github repo that simply manually copies your distribution and publish it to Meteor.
There is also a Blaze copy of Ionic Framework.
This PR will allow you to directly publish updated versions of Ionic as they become available. All you have to do is create an account at https://meteor.com/ (click SIGN IN, then Create account). After you've done that, please let me know the name of the account, and I'll add you as a maintainer to the driftyco organization there.
I've already published the current version of the package on Atmosphere (Meteor's package directory). When you release new versions of Ionic, you'll be able to publish them easily to Atmosphere.
As discussed by email, usually I also add the build process for automatically publishing the Meteor package but your build process is a little bit more complicated so as you requested, this pull request contains only the Meteor package files without any automatic scripts.
Thanks & best regards,
Uri