Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensuring that $scope.onScroll gets defined scrollLeft- and scrollTop-values #659

Closed
wants to merge 1 commit into from
Closed

Ensuring that $scope.onScroll gets defined scrollLeft- and scrollTop-values #659

wants to merge 1 commit into from

Conversation

herschel666
Copy link

Hi.

I sometimes got errors when the $element.scroll-binding had no proper object to get the scrollTop- and scrollLeft-properties from. That's when neither e.detail nor e.originalEvent.deail is defined. The previous solution basing on ternary operators didn't catch this option.

So I bloated the callback-function and added some "if-else-fugliness". What do you think?

Best regards
Emanuel

@adamdbradley
Copy link
Contributor

Thanks, @ajoslin will take a look at this.

@ajoslin ajoslin closed this in 978e442 Feb 21, 2014
@ajoslin
Copy link
Contributor

ajoslin commented Feb 21, 2014

Good catch @herschel666! I took a slightly difference approach and fixed it in 9e942f8.

Thanks for the report and help 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants