bug: $ionicLoading.show() uses last value of duration if it isn't passed

[tomf009]

Docs indicate $ionicLoading will show until hide() is called. But if you call show() with a duration, the next call to show() that doesn't have duration will use the previous call's duration. Looks like $ionicLoadingConfig is storing that previous call's value. Probably an issue for the other options as well.

Here's a CodePen where you can experience this behavior.

http://codepen.io/anon/pen/alhvo

Example:

$ionicLoading.show({
  template: 'This will show until hide() is called'
});

$ionicLoading.show({
  template: 'This will only show for a second',
  duration: 1000
});

$ionicLoading.show({
  template: 'Uh oh, this only shows for a second too! Even though there is no duration.'
});

Expected:
$ionicLoading.show() should behave consistently across multiple calls with different options.

Actual:
Options from previous calls to $ionicLoading.show() are being stored in $ionicLoadingConfig which effects the next calls to show().

Thanks for the great work on the framework! 🍻

[perrygovier]

Good catch. All fixed up, thanks.

[ionitron-bot]

Thanks for the issue! This issue is being locked to prevent comments that are not relevant to the original issue. If this is still an issue with the latest version of Ionic, please create a new issue and ensure the template is fully filled out.