Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong top border on <ion-footer-bar> with retina devices #1661

Closed
ohh2ahh opened this issue Jun 23, 2014 · 4 comments
Closed

Wrong top border on <ion-footer-bar> with retina devices #1661

ohh2ahh opened this issue Jun 23, 2014 · 4 comments
Assignees

Comments

@ohh2ahh
Copy link

ohh2ahh commented Jun 23, 2014

The top border of the footer gets rendered wrong on retina devices. As far as I know, you change the background-position to the top but you don't adjust the background-image: linear-gradient(...);. Because the transparent 1 px border is on top of the real border you get a "double border". I know, this is a very minor issue 😉

/* 1 px transparent border above real border */
background-image: linear-gradient(0deg, $bar-default-border, $bar-default-border 50%, transparent 50%);

/* Fix */
background-image: linear-gradient(180deg, $bar-default-border, $bar-default-border 50%, transparent 50%);

I tested it with v1.0.0-beta.8 on iOS.

@perrygovier
Copy link
Contributor

Hey @ohh2ahh, could you put together an example in codepen or provide some screenshots?

@perrygovier perrygovier self-assigned this Jun 23, 2014
@ohh2ahh
Copy link
Author

ohh2ahh commented Jun 24, 2014

Hi

Here is the CodePen (obviously, it works only on a retina device):
http://codepen.io/anon/pen/oaAdt

And here is a screenshot of the border, before and after the fix described above:
b13288f2-fbce-11e3-9793-38a824416c2c

@perrygovier
Copy link
Contributor

Great find @ohh2ahh! fixing now.

@ionitron-bot
Copy link

ionitron-bot bot commented Sep 6, 2018

Thanks for the issue! This issue is being locked to prevent comments that are not relevant to the original issue. If this is still an issue with the latest version of Ionic, please create a new issue and ensure the template is fully filled out.

@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Sep 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants