-
Notifications
You must be signed in to change notification settings - Fork 13.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
$ionicModal's remove() doesn't remove an element properly #1138
Comments
@adamdbradley what was the motivation for changing it from .remove() to this? |
If I recall, it was just an HTML element, and not an angular element, so remove() was causing errors for browsers that don't support it. But yes, this should have been updated to use the angular way. |
OK, sounds good then - I'll put it on remove(). |
Thanks for the issue! This issue is being locked to prevent comments that are not relevant to the original issue. If this is still an issue with the latest version of Ionic, please create a new issue and ensure the template is fully filled out. |
Currently, calling
.remove()
on an $ionicModal doesn't use the jQuery/jqLite method to remove the element from the DOM (code)This prevents the cleaning of
.data()
on the element, but also prevents angular from firing the$destroy
event (which some directives make use of)The text was updated successfully, but these errors were encountered: