-
Notifications
You must be signed in to change notification settings - Fork 13.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ion-view title won't update (with fix!) #1121
Comments
Hi! I don't actually understand your problem, your codepen is a bit too complicated for me to understand. Could you simplify the codepen or explain simply what's wrong? Thanks :-) |
Hello there! Let's start anew and forget the post#1 (except for the solution :-) ) I created a video showing the bug (watch it first): The bug in short is: choosing the items does not make a problem (in terms of the page1 title gets updated), until one visits the page2. From this point on, one can change the activeItem to another one, but when you try to change it back, the title won't update!!! It seems, that always THAT title is bugged, which was active when visiting page2. See the video for a good example. Here is a plnkr to experience the bug yourself: The suggestion made in post#1 fixes this bug. Thank you for spending time on this bug :-) |
OK, I understand now! If you have a view where the title changes back and forth, then goes back to the original, it won't work. I fixed it a different way. It works now in the nightly builds and will be in beta.5. |
NICE! I had some hacky code to overcome this bug! Hadn't found time to do a repo for you hence why I haven't reported it. Awesome! |
Thanks for the issue! This issue is being locked to prevent comments that are not relevant to the original issue. If this is still an issue with the latest version of Ionic, please create a new issue and ensure the template is fully filled out. |
EDIT:
This post was really confusing to read. Please start reading on post#3. When you want a possible solution to the bug, you can continue to read here (post#1):
What can be changed in the ionic.bundle.js to fix this bug? It is one simple line of code in the ionView directive: the lines
have to be changed to
Would be nice if you'd confirm this and implement it.
The text was updated successfully, but these errors were encountered: