Skip to content

Commit

Permalink
fix(scroll): Fix scroll for devices w/out dataset support, closes #976
Browse files Browse the repository at this point in the history
  • Loading branch information
Adam Bradley committed Mar 31, 2014
1 parent 3e188ca commit bfcf265
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion js/views/scrollView.js
Original file line number Diff line number Diff line change
Expand Up @@ -623,7 +623,7 @@ ionic.views.Scroll = ionic.views.View.inherit({
return e.target.tagName.match(IS_INPUT_LIKE_REGEX) ||
e.target.isContentEditable ||
e.target.tagName.match(IS_EMBEDDED_OBJECT_REGEX) ||
e.target.dataset.preventScroll;
e.target.dataset ? e.target.dataset.preventScroll : e.target.getAttribute('data-prevent-default') == 'true';
}


Expand Down

2 comments on commit bfcf265

@igmakis
Copy link

@igmakis igmakis commented on bfcf265 Apr 3, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, first of all thank you for this fix, but it seams it has a side-effect that is far beyond my comprehension. After applying this fix all my select (drop-down) elements stopped working. Any suggestions? Thanks, Igor

@chanthus
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi,

Any more update on this select element not working issue?

Please sign in to comment.