Skip to content

Commit 94bcbf7

Browse files
committed
fix(collectionRepeat): allow angular expressions properly
1 parent 46291d6 commit 94bcbf7

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed

js/angular/directive/collectionRepeat.js

+5-5
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@
4646
* <div class="list">
4747
* <div class="item my-item"
4848
* collection-repeat="item in items"
49-
* collection-item-width="100%"
49+
* collection-item-width="'100%'"
5050
* collection-item-height="getItemHeight(item, $index)"
5151
* ng-style="{height: getItemHeight(item, $index)}">
5252
* {% raw %}{{item}}{% endraw %}
@@ -80,8 +80,8 @@
8080
* <ion-content>
8181
* <div class="item item-avatar my-image-item"
8282
* collection-repeat="image in images"
83-
* collection-item-width="33%"
84-
* collection-item-height="33%">
83+
* collection-item-width="'33%'"
84+
* collection-item-height="'33%'">
8585
* <img ng-src="{{image.src}}">
8686
* </div>
8787
* </ion-content>
@@ -151,8 +151,8 @@ function($collectionRepeatManager, $collectionDataSource, $parse) {
151151
} else if (!isVertical && !$attr.collectionItemWidth) {
152152
throw new Error("collection-repeat expected attribute collection-item-width to be a an expression that returns a number.");
153153
}
154-
$attr.collectionItemHeight = $attr.collectionItemHeight || '100%';
155-
$attr.collectionItemWidth = $attr.collectionItemWidth || '100%';
154+
$attr.collectionItemHeight = $attr.collectionItemHeight || '"100%"';
155+
$attr.collectionItemWidth = $attr.collectionItemWidth || '"100%"';
156156

157157
var heightParsed = $attr.collectionItemHeight ?
158158
$parse($attr.collectionItemHeight) :

0 commit comments

Comments
 (0)