Skip to content

Commit 7ec0605

Browse files
author
Adam Bradley
committed
fix(button): Tweak vertical alignment of button icons, closes #739
1 parent 24524f7 commit 7ec0605

File tree

2 files changed

+7
-6
lines changed

2 files changed

+7
-6
lines changed

scss/_button.scss

+4-4
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@
5151
padding: 0 0 $button-border-width 0;
5252
vertical-align: inherit;
5353
font-size: $button-icon-size;
54-
line-height: $button-height - $button-border-width;
54+
line-height: $button-height - $button-border-width + 1;
5555
}
5656
&.icon-left:before {
5757
float: left;
@@ -164,7 +164,7 @@
164164
border-color: transparent;
165165
background: none;
166166

167-
&.button:active,
167+
&.button:active,
168168
&.button.active {
169169
border-color: transparent;
170170
background: none;
@@ -206,8 +206,8 @@
206206
.button-block {
207207
display: block;
208208
clear: both;
209-
210-
&:after {
209+
210+
&:after {
211211
clear: both;
212212
}
213213
}

test/html/buttons.html

+3-2
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
filter: progid:DXImageTransform.Microsoft.gradient( startColorstr='#00000000', endColorstr='#a6000000',GradientType=1 ); /* IE6-9 */
1616
}
1717
</style>
18-
<script src="../dist/js/ionic.bundle.js"></script>
18+
<script src="../../dist/js/ionic.bundle.js"></script>
1919
<script>
2020
angular.module('ionicApp', ['ionic'])
2121
</script>
@@ -67,7 +67,8 @@ <h3>a.button default</h3>
6767
<a class="button button-assertive"><i class="icon ion-home"></i></a>
6868
<a class="button button-energized"><i class="icon ion-home"></i> .button-energized</a>
6969
<a class="button button-royal">.button-royal</a>
70-
<a class="button button-dark"><i class="icon ion-home"></i> .button-dark</a>
70+
<a class="button button-dark"><i class="icon ion-chevron-right"></i> .button-dark</a>
71+
<a class="button button-energized icon-right ion-chevron-right">Login</a>
7172
</p>
7273

7374
<hr>

0 commit comments

Comments
 (0)