Skip to content

Commit 0c5c675

Browse files
author
Adam Bradley
committed
fix(sideMenu): Close side-menu if open and content tapped, closes #648
1 parent 159e0b9 commit 0c5c675

File tree

1 file changed

+8
-5
lines changed

1 file changed

+8
-5
lines changed

js/ext/angular/src/directive/ionicSideMenu.js

+8-5
Original file line numberDiff line numberDiff line change
@@ -65,11 +65,13 @@ angular.module('ionic.ui.sideMenu', ['ionic.service.gesture', 'ionic.service.vie
6565
var isDragging = false;
6666

6767
// Listen for taps on the content to close the menu
68-
/*
69-
ionic.on('tap', function(e) {
70-
sideMenuCtrl.close();
71-
}, $element[0]);
72-
*/
68+
function contentTap(e) {
69+
if(sideMenuCtrl.getOpenAmount() !== 0) {
70+
sideMenuCtrl.close();
71+
e.gesture.srcEvent.preventDefault();
72+
}
73+
}
74+
ionic.on('tap', contentTap, $element[0]);
7375

7476
var dragFn = function(e) {
7577
if($scope.dragContent) {
@@ -139,6 +141,7 @@ angular.module('ionic.ui.sideMenu', ['ionic.service.gesture', 'ionic.service.vie
139141
$ionicGesture.off(dragUpGesture, 'dragup', dragFn);
140142
$ionicGesture.off(dragDownGesture, 'dragdown', dragFn);
141143
$ionicGesture.off(releaseGesture, 'release', dragReleaseFn);
144+
ionic.off('tap', contentTap, $element[0]);
142145
});
143146
};
144147
}

0 commit comments

Comments
 (0)