fix(): ensure params are passed correctly to app-scripts

ionic-team · Nov 10, 2016 · 9c5ebed · 9c5ebed
1 parent 3fde646
commit 9c5ebed
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/lib/ionic/serve.js b/lib/ionic/serve.js
@@ -59,7 +59,7 @@ var settings =  {
   isProjectTask: true
 };
 
-function run(ionic, argv) {
+function run(ionic, argv, rawCliArguments) {
 
   /**
    * Before running the internal server check to see if npmscripts has 
@@ -68,7 +68,7 @@ function run(ionic, argv) {
   return npmScripts.hasIonicScript('serve')
     .then(function(hasServeCommand) {
       if (hasServeCommand) {
-        return npmScripts.runIonicScript('serve', argv);
+        return npmScripts.runIonicScript('serve', rawCliArguments.slice(1));
       } else {
         return runServer(argv);
       }

diff --git a/lib/utils/npmScripts.js b/lib/utils/npmScripts.js
@@ -23,7 +23,7 @@ function runIonicScript(name, argv) {
   var scriptName = getScriptName(name);
   var q = Q.defer();
 
-  var scriptSpawn = spawn('npm', ['run', scriptName].concat(argv || []), { stdio: 'inherit' })
+  var scriptSpawn = spawn('npm', ['run', scriptName, '--'].concat(argv || []), { stdio: 'inherit' })
     .on('error', function(err) {
       log.debug('Spawn command', scriptName, 'failed');
       q.reject('Unable to run spawn command ' + err);