[ci-review] Rector Rectify

Author: actions-user

config/sets/laravel-array-str-functions-to-static-call.php

@@ -11,7 +11,6 @@
 // @see https://laravel.com/docs/5.7/facades#facades-vs-dependency-injection
 
 return static function (RectorConfig $rectorConfig): void {
-
     $rectorConfig->import(__DIR__ . '/../config.php');
 
     $internalFunctions = get_defined_functions()['internal'];
@@ -64,7 +63,7 @@
                     new FuncCallToStaticCall('studly_case', 'Illuminate\Support\Str', 'studly'),
                     new FuncCallToStaticCall('title_case', 'Illuminate\Support\Str', 'title'),
                 ],
-                fn($function) => ! in_array($function->getOldFuncName(), $internalFunctions)
+                fn ($function) => ! in_array($function->getOldFuncName(), $internalFunctions, true)
             )
         );
 };

src/NodeFactory/ModelFactoryNodeFactory.php

@@ -125,7 +125,7 @@ function (Node $node) use ($closure, $name): ?Return_ {
                     return null;
                 }
 
-                if ($node->expr === null) {
+                if (! $node->expr instanceof Expr) {
                     return null;
                 }
 

src/Rector/ClassMethod/AddGenericReturnTypeToRelationsRector.php

@@ -125,7 +125,7 @@ public function refactorWithScope(Node $node, Scope $scope): ?Node
         // Don't update an existing return type if it differs from the native return type (thus the one without generics).
         // E.g. we only add generics to an existing return type, but don't change the type itself.
         if (
-            $phpDocInfo->getReturnTagValue() !== null
+            $phpDocInfo->getReturnTagValue() instanceof ReturnTagValueNode
             && ! $this->areNativeTypeAndPhpDocReturnTypeEqual(
                 $node,
                 $methodReturnType,
@@ -151,7 +151,7 @@ public function refactorWithScope(Node $node, Scope $scope): ?Node
         // Don't update the docblock if return type already contains the correct generics. This avoids overwriting
         // non-FQCN with our fully qualified ones.
         if (
-            $phpDocInfo->getReturnTagValue() !== null
+            $phpDocInfo->getReturnTagValue() instanceof ReturnTagValueNode
             && $this->areGenericTypesEqual(
                 $node,
                 $phpDocInfo->getReturnTagValue(),
@@ -168,7 +168,7 @@ public function refactorWithScope(Node $node, Scope $scope): ?Node
         );
 
         // Update or add return tag
-        if ($phpDocInfo->getReturnTagValue() !== null) {
+        if ($phpDocInfo->getReturnTagValue() instanceof ReturnTagValueNode) {
             $phpDocInfo->getReturnTagValue()
                 ->type = $genericTypeNode;
         } else {

src/Rector/ClassMethod/MigrateToSimplifiedAttributeRector.php

@@ -4,6 +4,7 @@
 
 namespace RectorLaravel\Rector\ClassMethod;
 
+use PhpParser\Comment\Doc;
 use PhpParser\Node;
 use PhpParser\Node\Arg;
 use PhpParser\Node\Expr\Array_;
@@ -96,7 +97,7 @@ public function refactor(Node $node): ?Node
         // Preserve docblock
         $docComment = $node->getDocComment();
 
-        if ($docComment !== null) {
+        if ($docComment instanceof Doc) {
             $newNode->setDocComment($docComment);
         }
 

src/Rector/Class_/PropertyDeferToDeferrableProviderToRector.php

@@ -5,6 +5,7 @@
 namespace RectorLaravel\Rector\Class_;
 
 use PhpParser\Node;
+use PhpParser\Node\Expr;
 use PhpParser\Node\Name\FullyQualified;
 use PhpParser\Node\Stmt\Class_;
 use PhpParser\Node\Stmt\Property;
@@ -88,7 +89,7 @@ private function matchDeferWithFalseProperty(Class_ $class): ?Property
             }
 
             $onlyProperty = $property->props[0];
-            if ($onlyProperty->default === null) {
+            if (! $onlyProperty->default instanceof Expr) {
                 return null;
             }
 

src/Rector/MethodCall/LumenRoutesStringMiddlewareToArrayRector.php

@@ -115,7 +115,7 @@ private function getRouterMethodAttributes(MethodCall $methodCall): ?Array_
     private function findItemInArrayByKey(Array_ $array, string $keyName): ?ArrayItem
     {
         foreach ($array->items as $i => $item) {
-            if ($item === null) {
+            if (! $item instanceof ArrayItem) {
                 continue;
             }
             if (! $this->arrayManipulator->hasKeyName($item, $keyName)) {
@@ -133,7 +133,7 @@ private function findItemInArrayByKey(Array_ $array, string $keyName): ?ArrayIte
     private function replaceItemInArrayByKey(Array_ $array, ArrayItem $arrayItem, string $keyName): void
     {
         foreach ($array->items as $i => $item) {
-            if ($item === null) {
+            if (! $item instanceof ArrayItem) {
                 continue;
             }
             if (! $this->arrayManipulator->hasKeyName($item, $keyName)) {