From 928850677b1f30d30d90375c68afbcd3364e4c94 Mon Sep 17 00:00:00 2001 From: Rachit Gandhi <77197545+Rachit-Gandhi@users.noreply.github.com> Date: Sat, 5 Aug 2023 13:09:55 +0530 Subject: [PATCH 1/2] Update README.md --- README.md | 19 +++++++++++++++++++ 1 file changed, 19 insertions(+) diff --git a/README.md b/README.md index 07e79d39..b1c982c3 100644 --- a/README.md +++ b/README.md @@ -1,3 +1,22 @@ +This draft PR is focused on Feature Embedding + +#Feature request + +As requested by some, and as @ekamioka started on this PR #244. It might be interesting to get some helper functions to use embeddings as it's not the simplest concept in deep learning. + +#What is the expected behavior? +Calling a few helper function to get all the correct parameters before using TabNet. + +#What is motivation or use case for adding/changing the behavior? +I think this would make things easier and help a lot of people. + +How should this be implemented in your opinion? +Clean and clear, might be available in a helper.py file, completely independent of the rest of the code. + + + + + # README # TabNet : Attentive Interpretable Tabular Learning From 7beb67887b57ede1df3d0d80443edd7578d1fa3a Mon Sep 17 00:00:00 2001 From: Rachit Gandhi <77197545+Rachit-Gandhi@users.noreply.github.com> Date: Sat, 5 Aug 2023 13:11:39 +0530 Subject: [PATCH 2/2] Update README.md --- README.md | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/README.md b/README.md index b1c982c3..9b86e46e 100644 --- a/README.md +++ b/README.md @@ -1,16 +1,16 @@ This draft PR is focused on Feature Embedding -#Feature request +**Feature request** As requested by some, and as @ekamioka started on this PR #244. It might be interesting to get some helper functions to use embeddings as it's not the simplest concept in deep learning. -#What is the expected behavior? +**What is the expected behavior?** Calling a few helper function to get all the correct parameters before using TabNet. -#What is motivation or use case for adding/changing the behavior? +**#What is motivation or use case for adding/changing the behavior?** I think this would make things easier and help a lot of people. -How should this be implemented in your opinion? +**How should this be implemented in your opinion?** Clean and clear, might be available in a helper.py file, completely independent of the rest of the code.