Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong choice of candrabindu early in life #12

Closed
drdhaval2785 opened this issue Dec 17, 2017 · 4 comments
Closed

Wrong choice of candrabindu early in life #12

drdhaval2785 opened this issue Dec 17, 2017 · 4 comments

Comments

@drdhaval2785
Copy link
Owner

When I started to code SanskritVerb, I didnt read SLP1 specs properly and decided that it does not have a candrabindu. So I decided to use '!' for it. But correct choice is '~'. Now it is too difficult to change code internals. But during storage / emitting out / API calls, I think I should convert ! to ~.
@drdhaval2785
Copy link
Owner Author

screenshot_20171217-065211

See the error in transliteration here. Because I gave wrong letter.

@avinashvarna
Copy link
Contributor

I've temporarily fixed it in the UI (https://avinashvarna.github.io/prakriya/). We can fix it in the main module later.

@drdhaval2785 drdhaval2785 mentioned this issue Dec 17, 2017
Closed
@avinashvarna
Copy link
Contributor

The verbslp field of the results in
https://api.sanskritworld.in/v0.0.2/verbforms/slp1/jagAma?output_transliteration=devanagari
still has "!" instead of chandrabindu.

@drdhaval2785
Copy link
Owner Author

Yes. Just saw it. Will fix in API in evening

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@avinashvarna @drdhaval2785