Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cljs repl #5

Open
dturczanski opened this issue Jan 30, 2013 · 2 comments
Open

Cljs repl #5

dturczanski opened this issue Jan 30, 2013 · 2 comments

Comments

@dturczanski
Copy link

Hi,
I don't think it's possible to live code in the browser atm.

If I place a call:
(repl/connect "http://localhost:9000/repl")

an iframe is created but it is overwritten by WebFUI since it takes control of the whole body.

It would be great to use cljs repl. Is there a way to run it currently, or any possible workaround?

Thanks,
Daniel

@drcode
Copy link
Owner

drcode commented Jan 30, 2013

Thanks Daniel, I was not aware of the cljs repl feature and therefore am not surprised it doesn't work.

I suppose the library will need to have a check for cljs repl and play nice with it if it's in use. I will leave this issue open and will get to it when I can, but things are hectic in my life right now and it will probably be a while before I can get around to it.

@dturczanski
Copy link
Author

Hi Conrad, I took a look at this issue and ended up with these changes: dturczanski@ce36b0b

Thanks to this commit, the whole app DOM is put in the div (which's id property is hardcoded to "content") - not straight into the body.

I only tested the change using the basic calculator example and it works great. It is even possible to update the state atom from the REPL and see instant change in the web browser :)

Hope you find time to tell me what you think, are interested in pull requests?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants