Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mac: "Hide taskbar icon" setting not working as expected #27

Closed
youngboy opened this issue Aug 23, 2023 · 5 comments
Closed

Mac: "Hide taskbar icon" setting not working as expected #27

youngboy opened this issue Aug 23, 2023 · 5 comments
Labels
awaiting release Done and ready for the next release bug Something isn't working right

Comments

@youngboy
Copy link

When the "Hide Taskbar Icon" setting is enabled, the Obsidian icon still appears in the task switcher and the dock on macOS. Could this be due to the lack of a app.dock.hide() call for the macOS platform?

https://www.electronjs.org/docs/latest/api/dock#dockhide-macos

macOS version: 13.4

@dragonwocky
Copy link
Owner

Yes. Yes it could be. Thanks for the pickup - I'm not a mac user myself, so I have no way of testing these things. Interestingly, BrowserWindow.setSkipTaskbar() (which I do call) claims that it's macOS compatible, which makes me wonder what it is doing/what differentiates it from app.dock.hide().

@youngboy
Copy link
Author

maybe this is relate tauri-apps/tauri#4852 (comment)

@dragonwocky
Copy link
Owner

I've pushed a possible fix for this, if you could follow the manual installation instructions to test it out before I release it to the Obsidian marketplace that'd be really helpful. Thanks!

@dragonwocky dragonwocky reopened this Aug 23, 2023
@dragonwocky dragonwocky added the bug Something isn't working right label Aug 23, 2023
@youngboy
Copy link
Author

the fixes works for me, thanks

@dragonwocky
Copy link
Owner

awesome! thanks for testing :)

@dragonwocky dragonwocky reopened this Aug 23, 2023
@dragonwocky dragonwocky added the awaiting release Done and ready for the next release label Aug 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting release Done and ready for the next release bug Something isn't working right
Projects
None yet
Development

No branches or pull requests

2 participants