Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reopen all vaults when relaunching app #20

Open
Mercencium opened this issue Jul 5, 2023 · 2 comments
Open

Reopen all vaults when relaunching app #20

Mercencium opened this issue Jul 5, 2023 · 2 comments
Labels
enhancement New feature or request

Comments

@Mercencium
Copy link

Clicking 'Relaunch Obsidian' closes all the vault windows, but starts only the last one opened.
It doesn't matter if the other open vaults have this plugin or not - the behaviour is the same.

At least re-opening all the windows is expected.
But it would be better for this option to relaunch only the vault the tray icon belongs to.
For that matter, renaming 'Relaunch Obsidian' to 'Relaunch Vault' would be more clear.

@dragonwocky
Copy link
Owner

dragonwocky commented Jul 6, 2023

Hm.

It's not a 'relaunch vault' function. It's not meant to only close and reopen the current vault, and it's not meant to reopen every individual window. It's meant to close/stop the app completely, and then reopen/relaunch the app as if you had clicked the Obsidian shortcut in your start menu.

To compare: if I have multiple vaults open, kill Obsidian in task manager, and then launch Obsidian from the start menu - only one of those vaults will be re-opened. Not all of them. So, as far as I can tell, the 'relaunch Obsidian' function does behave exactly as it should, following expected default/system behaviour.

I think what you're asking for is a 'preserve vaults on relaunch' option, which would manually reopen all previously opened vaults on relaunch. I'm not sure if this is actually possible, as the separation of plugin instances across vaults and the fact that the app does fully quit and then relaunch (and so loses all local state) may make it difficult to find a way to reliably trigger which vaults should be reopened, but I'll leave this issue open until I can take a further look at it.

@dragonwocky dragonwocky changed the title Bug: 'Relaunch' closes all vaults, opens only one Reopen all vaults when relaunching app Jul 6, 2023
@dragonwocky dragonwocky added the enhancement New feature or request label Jul 6, 2023
@Mercencium
Copy link
Author

Mercencium commented Jul 6, 2023

I see, thank you for response.

So as far as I understand now, reopening all vaults is more Obsidian issue rather than this plugin's.
There was actually a similar feature request on Obsidian forum: Option: Open Last Used Vault or Open Vault Selector
Just noticed - when I restart my computer without closing the vaults first, then open Obsidian, it restores both vaults.

Unless you want to work on 'Relaunch Vault' option I would consider this issue closed.

@dragonwocky dragonwocky added next Out of scope for the current release, for later evaluation and removed next Out of scope for the current release, for later evaluation labels Aug 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants