Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feat] preheat supports authentication and rich format range #1237

Merged
merged 3 commits into from
Apr 20, 2022
Merged

[feat] preheat supports authentication and rich format range #1237

merged 3 commits into from
Apr 20, 2022

Conversation

yxxhero
Copy link
Member

@yxxhero yxxhero commented Apr 10, 2022 •
edited
Loading

Signed-off-by: yxxhero [email protected]

Description

Related Issue

#769

Motivation and Context

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

  • Code compiles correctly.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@yxxhero yxxhero requested a review from a team as a code owner April 10, 2022 01:52
@yxxhero yxxhero marked this pull request as draft April 10, 2022 01:53
@codecov-commenter
Copy link

codecov-commenter commented Apr 10, 2022 •
edited
Loading

Codecov Report

Merging #1237 (e23ca07) into main (0649293) will decrease coverage by 0.31%.
The diff coverage is 49.49%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1237      +/-   ##
==========================================
- Coverage   46.26%   45.95%   -0.32%     
==========================================
  Files         135      137       +2     
  Lines       11202    11440     +238     
==========================================
+ Hits         5183     5257      +74     
- Misses       5451     5594     +143     
- Partials      568      589      +21
Flag Coverage Δ
Object-compatibility-e2etests ?
e2etests ?
unittests 45.95% <49.49%> (-0.32%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
manager/job/preheat.go 35.98% <49.49%> (ø)
...ent/daemon/peer/peertask_piecetask_synchronizer.go 57.22% <0.00%> (-1.81%) ⬇️
manager/job/job.go 0.00% <0.00%> (ø)

@yxxhero yxxhero marked this pull request as ready for review April 16, 2022 01:32
@yxxhero yxxhero changed the title add containerd support preheat supports authentication and rich format range Apr 17, 2022
@yxxhero yxxhero changed the title preheat supports authentication and rich format range [feat] preheat supports authentication and rich format range Apr 17, 2022
@yxxhero yxxhero self-assigned this Apr 17, 2022
@yxxhero yxxhero linked an issue Apr 17, 2022 that may be closed by this pull request
Preheat can't process images from private project correctly #769
Open
@yxxhero yxxhero added this to the v2.0.3 milestone Apr 17, 2022
@gaius-qi gaius-qi changed the base branch from main to feature/preheat April 20, 2022 07:37
@gaius-qi gaius-qi merged commit eb5c751 into dragonflyoss:feature/preheat Apr 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@imeoer imeoer Awaiting requested review from imeoer imeoer was automatically assigned from dragonflyoss/dragonfly2-reviewers

@ansinlee ansinlee Awaiting requested review from ansinlee ansinlee was automatically assigned from dragonflyoss/dragonfly2-reviewers

@yangjun289519474 yangjun289519474 Awaiting requested review from yangjun289519474 yangjun289519474 was automatically assigned from dragonflyoss/dragonfly2-reviewers

Assignees

@yxxhero yxxhero

Labels
manager
Projects
None yet
Milestone
v2.0.3
Development

Successfully merging this pull request may close these issues.

Preheat can't process images from private project correctly
3 participants
@yxxhero @codecov-commenter @gaius-qi