Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use blob sha256 to generate taskID instead of download url #2033

Open
hyy0322 opened this issue Jan 31, 2023 · 2 comments
Open

Use blob sha256 to generate taskID instead of download url #2033

hyy0322 opened this issue Jan 31, 2023 · 2 comments
Assignees

Comments

@hyy0322
Copy link

hyy0322 commented Jan 31, 2023

Feature request:

Use blob sha256 to generate taskID.

func TaskID(url string, meta *commonv1.UrlMeta) string {
	return taskID(url, meta, false)
}

Currently dragonfly use image download url to generate task ID.

Use case:

Two different image share some same blobs. If image repo not the same, the url is not same. So task ID are different.The same cache will missed.

UI Example:

@yxxhero
Copy link
Member

yxxhero commented Jan 31, 2023

make sense

@gaius-qi
Copy link
Member

gaius-qi commented Feb 3, 2023

I will consider implementing in the rust client.

@gaius-qi gaius-qi self-assigned this Feb 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants